Changeset 185703 in webkit

Timestamp:

Jun 18, 2015, 10:13:21 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r185671.
​https://bugs.webkit.org/show_bug.cgi?id=146114

Caused frequent flaky failures on profiler tests (Requested by
ap on #webkit).

Reverted changeset:

"Web Inspector: Improve a few more node preview types"
​https://bugs.webkit.org/show_bug.cgi?id=146048
​http://trac.webkit.org/changeset/185671

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/FormattedValue.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-06-18  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r185671.
+        https://bugs.webkit.org/show_bug.cgi?id=146114
+
+        Caused frequent flaky failures on profiler tests (Requested by
+        ap on #webkit).
+
+        Reverted changeset:
+
+        "Web Inspector: Improve a few more node preview types"
+        https://bugs.webkit.org/show_bug.cgi?id=146048
+        http://trac.webkit.org/changeset/185671
+
 2015-06-17  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/FormattedValue.js

@@ -70 +70 @@
 WebInspector.FormattedValue.createElementForNodePreview = function(preview)
 {
-    var value = preview.value;
     var span = document.createElement("span");
     span.className = "formatted-node-preview syntax-highlighted";
 
-    // Comment node preview.
-    if (value.startsWith("<!--")) {
-        var comment = span.appendChild(document.createElement("span"));
-        comment.className = "html-comment";
-        comment.textContent = value;
-        return span;
-    }
-
-    // Doctype node preview.
-    if (value.startsWith("<!DOCTYPE")) {
-        var doctype = span.appendChild(document.createElement("span"));
-        doctype.className = "html-doctype";
-        doctype.textContent = value;
-        return span;
-    }
-
-    // Element node previews have a very strict format, with at most a single attribute.
+    // A node preview has a very strict format, with at most a single attribute.
     // We can style it up like a DOMNode without interactivity.
-    var matches = value.match(/^<(\S+?)(?: (\S+?)="(.*?)")?>$/);
-
-    // Remaining node types are often #text, #document, etc, with attribute nodes potentially being any string.
+    var matches = preview.value.match(/^<(\S+?)(?: (\S+?)="(.*?)")?>$/);
     if (!matches) {
-        console.assert(!value.startsWith("<"), "Unexpected node preview format: " + value);
-        span.textContent = value;
+        console.error("Node preview did not match format.", preview.value)
+        span.textContent = preview.value;
         return span;
     }