Changeset 185760 in webkit

Timestamp:

Jun 19, 2015, 12:10:31 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Revert switch to _synchronizedDrawingFence.
​https://bugs.webkit.org/show_bug.cgi?id=146136
<rdar://problem/21227992>

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-06-19
Reviewed by Simon Fraser.

Revert _synchronizedDrawingFence code path that leaks a port.

• UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerFrame):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WebVideoFullscreenManagerProxy.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-06-19  Jeremy Jones  <jeremyj@apple.com>
+
+        Revert switch to _synchronizedDrawingFence.
+        https://bugs.webkit.org/show_bug.cgi?id=146136
+        <rdar://problem/21227992>
+
+        Reviewed by Simon Fraser.
+
+        Revert _synchronizedDrawingFence code path that leaks a port.
+
+        * UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
+        (WebKit::WebVideoFullscreenManagerProxy::setVideoLayerFrame):
+
 2015-06-19  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm

@@ -39 +39 @@
 #import <WebKitSystemInterface.h>
 
-#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000
-#import "BackBoardServicesSPI.h"
-#endif
-
 using namespace WebCore;
 
@@ -517 +513 @@
 {
     @autoreleasepool {
-#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000
-        BKSAnimationFenceHandle* synchronizationFence = [UIWindow _synchronizedDrawingFence];
-        mach_port_name_t fencePort = [synchronizationFence CAPort];
-#else
         mach_port_name_t fencePort = [UIWindow _synchronizeDrawingAcrossProcesses];
-#endif
 
         m_page->send(Messages::WebVideoFullscreenManager::SetVideoLayerFrameFenced(contextId, frame, IPC::Attachment(fencePort, MACH_MSG_TYPE_MOVE_SEND)), m_page->pageID());