Changeset 185761 in webkit

Timestamp:

Jun 19, 2015, 12:10:51 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Fullscreen view should not update bounds of video when in PiP.
​https://bugs.webkit.org/show_bug.cgi?id=146134

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-06-19
Reviewed by Darin Adler.

Don't update bounds on video layer when it is not a child.

• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVVideoLayer setBounds:]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-19  Jeremy Jones  <jeremyj@apple.com>
+
+        Fullscreen view should not update bounds of video when in PiP.
+        https://bugs.webkit.org/show_bug.cgi?id=146134
+
+        Reviewed by Darin Adler.
+
+        Don't update bounds on video layer when it is not a child.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (-[WebAVVideoLayer setBounds:]):
+
 2015-06-19  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm

@@ -694 +694 @@
     [super setBounds:bounds];
 
-    [_videoSublayer setPosition:CGPointMake(CGRectGetMidX(bounds), CGRectGetMidY(bounds))];
-    [_videoSublayer setBounds:bounds];
+    if ([_videoSublayer superlayer] == self) {
+        [_videoSublayer setPosition:CGPointMake(CGRectGetMidX(bounds), CGRectGetMidY(bounds))];
+        [_videoSublayer setBounds:bounds];
+    }
 }