Changeset 185786 in webkit

Timestamp:

Jun 19, 2015, 6:24:55 PM (11 years ago)

Author:

Michael Catanzaro

Message:

Fix absolute value warning in LocalizedStringsGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=145919

Reviewed by Martin Robinson.

Use abs(static_cast<int>(time)) rather than static_cast<int>(abs(time)) to avoid clang's
warnings about passing a float to abs() instead of std::abs(). Also, because casting an int
to an int is silly.

• platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaTimeDescription):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/LocalizedStringsGtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Fix absolute value warning in LocalizedStringsGtk.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=145919
+
+        Reviewed by Martin Robinson.
+
+        Use abs(static_cast<int>(time)) rather than static_cast<int>(abs(time)) to avoid clang's
+        warnings about passing a float to abs() instead of std::abs(). Also, because casting an int
+        to an int is silly.
+
+        * platform/gtk/LocalizedStringsGtk.cpp:
+        (WebCore::localizedMediaTimeDescription):
+
 2015-06-19  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp

@@ -665 +665 @@
         return String::fromUTF8(_("indefinite time"));
 
-    int seconds = static_cast<int>(abs(time));
+    int seconds = abs(static_cast<int>(time));
     int days = seconds / (60 * 60 * 24);
     int hours = seconds / (60 * 60);