Changeset 185799 in webkit

Timestamp:

Jun 20, 2015, 1:50:35 PM (11 years ago)

Author:

Chris Dumez

Message:

[WK2][iOS] Avoid synchronous IPC on view state change when the content is not visible
​https://bugs.webkit.org/show_bug.cgi?id=146179
<rdar://problem/20923432>

Reviewed by Tim Horton.

After r170787, viewStateChange() would cause a synchronous IPC between
the UIProcess and the WebProcess when the view becomes visible. This
was to avoid painting empty / black tiles when unsuspending the
WebProcess on tab switch, in the event volatile IOSurfaces were purged.

However, this sync IPC can have performance implications and is not
needed when the content is not actually visible yet (e.g.
hideContentUntilNextUpdate() was called, or the tab was killed).

This patch avoids the synchronous IPC when the content is hidden and
exposes a private API on WKWebView so that clients can ask for the
content to be hidden until the next update. This would allow for
clients to avoid the synchronous IPC if they don't need the content
to be displayed synchronously (e.g. the view is obscured).

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _hideContentUntilNextUpdate]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::hasVisibleContent):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchViewStateChange):

• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::isContentHidden):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebViewPrivate.h (modified) (1 diff)
• UIProcess/DrawingAreaProxy.h (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h (modified) (2 diffs)
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-06-20  Chris Dumez  <cdumez@apple.com>
+
+        [WK2][iOS] Avoid synchronous IPC on view state change when the content is not visible
+        https://bugs.webkit.org/show_bug.cgi?id=146179
+        <rdar://problem/20923432>
+
+        Reviewed by Tim Horton.
+
+        After r170787, viewStateChange() would cause a synchronous IPC between
+        the UIProcess and the WebProcess when the view becomes visible. This
+        was to avoid painting empty / black tiles when unsuspending the
+        WebProcess on tab switch, in the event volatile IOSurfaces were purged.
+
+        However, this sync IPC can have performance implications and is not
+        needed when the content is not actually visible yet (e.g.
+        hideContentUntilNextUpdate() was called, or the tab was killed).
+
+        This patch avoids the synchronous IPC when the content is hidden and
+        exposes a private API on WKWebView so that clients can ask for the
+        content to be hidden until the next update. This would allow for
+        clients to avoid the synchronous IPC if they don't need the content
+        to be displayed synchronously (e.g. the view is obscured).
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _hideContentUntilNextUpdate]):
+        * UIProcess/API/Cocoa/WKWebViewPrivate.h:
+        * UIProcess/DrawingAreaProxy.h:
+        (WebKit::DrawingAreaProxy::hasVisibleContent):
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::dispatchViewStateChange):
+        * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
+        * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
+        (WebKit::RemoteLayerTreeDrawingAreaProxy::isContentHidden):
+
 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

@@ -2592 +2592 @@
 }
 
+- (void)_hideContentUntilNextUpdate
+{
+    if (auto* area = _page->drawingArea())
+        area->hideContentUntilNextUpdate();
+}
+
 - (void)_beginAnimatedResizeWithUpdates:(void (^)(void))updateBlock
 {

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h

@@ -135 +135 @@
 - (void)_beginInteractiveObscuredInsetsChange;
 - (void)_endInteractiveObscuredInsetsChange;
+- (void)_hideContentUntilNextUpdate;
 
 - (void)_beginAnimatedResizeWithUpdates:(void (^)(void))updateBlock;

trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h

@@ -91 +91 @@
 
     virtual void hideContentUntilNextUpdate() { ASSERT_NOT_REACHED(); }
+    virtual bool hasVisibleContent() const { return true; }
 
     virtual void willSendUpdateGeometry() { }

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -1373 +1373 @@
 
     // We always want to wait for the Web process to reply if we've been in-window before and are coming back in-window.
-    if (m_viewWasEverInWindow && (changed & ViewState::IsInWindow) && isInWindow())
+    if (m_viewWasEverInWindow && (changed & ViewState::IsInWindow) && isInWindow() && m_drawingArea->hasVisibleContent())
         m_viewStateChangeWantsSynchronousReply = true;
 

trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h

@@ -40 +40 @@
 class RemoteScrollingCoordinatorTransaction;
 
-class RemoteLayerTreeDrawingAreaProxy : public DrawingAreaProxy {
+class RemoteLayerTreeDrawingAreaProxy final : public DrawingAreaProxy {
 public:
     explicit RemoteLayerTreeDrawingAreaProxy(WebPageProxy&);
@@ -78 +78 @@
     virtual void waitForDidUpdateViewState() override;
     virtual void hideContentUntilNextUpdate() override;
+    virtual bool hasVisibleContent() const override;
     
     WebCore::FloatPoint indicatorLocation() const;

trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm

@@ -422 +422 @@
 }
 
+bool RemoteLayerTreeDrawingAreaProxy::hasVisibleContent() const
+{
+    return m_remoteLayerTreeHost.rootLayer();
+}
+
 } // namespace WebKit