Context Navigation

Changeset 185809 in webkit

Timestamp:

Jun 21, 2015, 8:57:04 AM (11 years ago)

Author:

ddkilzer@apple.com

Message:

fast/css-grid-layout/flex-content-sized-columns-resize.html is flaky

The Flakiness Dashboard says this test is flaky on Apple and EFL
WebKit2 platforms:

It currently doesn't wait for window.resize() to complete, which
is likely the source of flakiness.

Switch to using notifyDone() inside a window.onresize function,
and make the test work in a web browser without TestRunner.

Location:

trunk/LayoutTests

Files:

-              r185798
+              r185809
+-06-21  David Kilzer  <ddkilzer@apple.com>
+        fast/css-grid-layout/flex-content-sized-columns-resize.html is flaky
+        The Flakiness Dashboard says this test is flaky on Apple and EFL
+        WebKit2 platforms:
+        <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss-grid-layout%2Fflex-content-sized-columns-resize.html>
+        It currently doesn't wait for window.resize() to complete, which
+        is likely the source of flakiness.
+        * fast/css-grid-layout/flex-content-sized-columns-resize.html:
+        Switch to using notifyDone() inside a window.onresize function,
+        and make the test work in a web browser without TestRunner.
 -06-20  David Kilzer  <ddkilzer@apple.com>

-              r168416
+              r185809
 </style>
 <script>
 function runTest() {
+window.onload = function () {
     if (window.testRunner) {
+        window.resizeTo(600, 600);
+        testRunner.waitUntilDone();
+    }
+    window.resizeTo(600, 600);
+}
+window.onresize = function () {
+    if (window.testRunner) {
+        testRunner.notifyDone();
+    }
+}
 </script>
 </head>
 <body onLoad="runTest();">
+<body>
     <h1>Description</h1>
     <p>Grid flex and content sized columns width should be updated properly when you resize the window (you should not see the grid background in grey color).</p>

Note: See TracChangeset for help on using the changeset viewer.