Changeset 18584 in webkit

Timestamp:

Jan 4, 2007, 10:58:51 AM (18 years ago)

Author:

kmccullo

Message:

Reviewed by Kevin McCullough.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12070 REGRESSION: KJS::getUTCOffset() caches UTC offset but ignores time zone changes

• kjs/DateMath.cpp: (KJS::getUTCOffset): Don't cache UTC offset.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/DateMath.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-01-04  David Kilzer  <ddkilzer@webkit.org>
+
+        Reviewed by Kevin McCullough.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12070
+          REGRESSION: KJS::getUTCOffset() caches UTC offset but ignores time zone changes
+
+        * kjs/DateMath.cpp:
+        (KJS::getUTCOffset): Don't cache UTC offset.
+
 2007-01-02  Darin Adler  <darin@apple.com>
 

trunk/JavaScriptCore/kjs/DateMath.cpp

@@ -294 +294 @@
  */
 double getUTCOffset() {
-    static double utcOffset;
-    static bool utcOffsetInitialized = false;
-    if (!utcOffsetInitialized) {
-        tm localt;
-
-        memset(&localt, 0, sizeof(localt));
-
-        // get the difference between this time zone and UTC on Jan 01, 2000 12:00:00 AM
-        localt.tm_mday = 1;
-        localt.tm_year = 100;
-        utcOffset = 946684800.0 - mktime(&localt);
-
-        utcOffset *= msPerSecond;
-
-        utcOffsetInitialized = true;
-    }
+    tm localt;
+
+    memset(&localt, 0, sizeof(localt));
+
+    // get the difference between this time zone and UTC on Jan 01, 2000 12:00:00 AM
+    localt.tm_mday = 1;
+    localt.tm_year = 100;
+    double utcOffset = 946684800.0 - mktime(&localt);
+
+    utcOffset *= msPerSecond;
+
     return utcOffset;
 }