Changeset 186289 in webkit

Timestamp:

Jul 5, 2015 11:46:54 AM (9 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Deleting in the CSS sidebar causes the warning icon to appear mid-word
​https://bugs.webkit.org/show_bug.cgi?id=146617

Reviewed by Timothy Hatcher.

• UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleBeforeChange): Now removes all marks whenever the user deletes.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): The invalid marker now calculates
it's position based off of where the semicolon is in the property text.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDeclarationTextEditor.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-07-05  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Deleting in the CSS sidebar causes the warning icon to appear mid-word
+        https://bugs.webkit.org/show_bug.cgi?id=146617
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+        (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleBeforeChange): Now removes all marks whenever the user deletes.
+        (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): The invalid marker now calculates
+        it's position based off of where the semicolon is in the property text.
+
 2015-07-05  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js

@@ -442 +442 @@
     _handleBeforeChange(codeMirror, change)
     {
-        if (change.origin !== "+delete" || change.to.ch)
+        if (change.origin !== "+delete")
             return CodeMirror.Pass;
 
@@ -997 +997 @@
         if (propertyNameIsValid) {
             // The property's name is valid but its value is not (either it is not supported for this property or there is no value).
-            var start = {line: from.line, ch: from.ch + property.name.length + 2};
+            var semicolon = /:\s*/.exec(property.text);
+            var start = {line: from.line, ch: semicolon.index + semicolon[0].length};
             var end = {line: to.line, ch: start.ch + property.value.length};