Changeset 186289 in webkit
- Timestamp:
- Jul 5, 2015 11:46:54 AM (9 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r186288 r186289 1 2015-07-05 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Deleting in the CSS sidebar causes the warning icon to appear mid-word 4 https://bugs.webkit.org/show_bug.cgi?id=146617 5 6 Reviewed by Timothy Hatcher. 7 8 * UserInterface/Views/CSSStyleDeclarationTextEditor.js: 9 (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleBeforeChange): Now removes all marks whenever the user deletes. 10 (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): The invalid marker now calculates 11 it's position based off of where the semicolon is in the property text. 12 1 13 2015-07-05 Devin Rousso <drousso@apple.com> 2 14 -
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js
r186286 r186289 442 442 _handleBeforeChange(codeMirror, change) 443 443 { 444 if (change.origin !== "+delete" || change.to.ch)444 if (change.origin !== "+delete") 445 445 return CodeMirror.Pass; 446 446 … … 997 997 if (propertyNameIsValid) { 998 998 // The property's name is valid but its value is not (either it is not supported for this property or there is no value). 999 var start = {line: from.line, ch: from.ch + property.name.length + 2}; 999 var semicolon = /:\s*/.exec(property.text); 1000 var start = {line: from.line, ch: semicolon.index + semicolon[0].length}; 1000 1001 var end = {line: to.line, ch: start.ch + property.value.length}; 1001 1002
Note: See TracChangeset
for help on using the changeset viewer.