Changeset 186634 in webkit

Timestamp:

Jul 9, 2015 2:54:11 PM (9 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Special Logs to Console that do not have an expression should be styled differently, looks like code
​https://bugs.webkit.org/show_bug.cgi?id=143840

Reviewed by Timothy Hatcher.

• UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.WebInspector.JavaScriptLogViewController.appendImmediateExecutionWithResult):
Now applies a class to special logs initiated by the user (log element, log object, etc).

• UserInterface/Views/ConsoleCommandView.js:

(WebInspector.ConsoleCommandView): Added className parameter.

• UserInterface/Views/ConsoleMessageView.css:

(.console-user-command.selected-element-log):
(.console-user-command.special-user-log > .console-message-text):

• UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
(WebInspector.DOMTreeOutline.prototype._populateContextMenu):

• UserInterface/Views/ObjectPreviewView.js:

(WebInspector.ObjectPreviewView.prototype._contextMenuHandler):

• UserInterface/Views/ObjectTreeBaseTreeElement.js:

(WebInspector.ObjectTreeBaseTreeElement.prototype._logSymbolProperty):
(WebInspector.ObjectTreeBaseTreeElement.prototype._logValue):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/JavaScriptLogViewController.js (modified) (1 diff)
• UserInterface/Views/ConsoleCommandView.js (modified) (2 diffs)
• UserInterface/Views/ConsoleMessageView.css (modified) (1 diff)
• UserInterface/Views/DOMTreeOutline.js (modified) (1 diff)
• UserInterface/Views/ObjectPreviewView.js (modified) (1 diff)
• UserInterface/Views/ObjectTreeBaseTreeElement.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-07-09  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Special Logs to Console that do not have an expression should be styled differently, looks like code
+        https://bugs.webkit.org/show_bug.cgi?id=143840
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Controllers/JavaScriptLogViewController.js:
+        (WebInspector.WebInspector.JavaScriptLogViewController.appendImmediateExecutionWithResult):
+        Now applies a class to special logs initiated by the user (log element, log object, etc).
+        * UserInterface/Views/ConsoleCommandView.js:
+        (WebInspector.ConsoleCommandView): Added className parameter.
+        * UserInterface/Views/ConsoleMessageView.css:
+        (.console-user-command.selected-element-log):
+        (.console-user-command.special-user-log > .console-message-text):
+        * UserInterface/Views/DOMTreeOutline.js:
+        (WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
+        (WebInspector.DOMTreeOutline.prototype._populateContextMenu):
+        * UserInterface/Views/ObjectPreviewView.js:
+        (WebInspector.ObjectPreviewView.prototype._contextMenuHandler):
+        * UserInterface/Views/ObjectTreeBaseTreeElement.js:
+        (WebInspector.ObjectTreeBaseTreeElement.prototype._logSymbolProperty):
+        (WebInspector.ObjectTreeBaseTreeElement.prototype._logValue):
+
 2015-07-09  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js

@@ -120 +120 @@
     }
 
-    appendImmediateExecutionWithResult(text, result)
+    appendImmediateExecutionWithResult(text, result, addSpecialUserLogClass)
     {
         console.assert(result instanceof WebInspector.RemoteObject);
 
-        var commandMessageView = new WebInspector.ConsoleCommandView(text);
+        var commandMessageView = new WebInspector.ConsoleCommandView(text, addSpecialUserLogClass ? "special-user-log" : null);
         this._appendConsoleMessageView(commandMessageView, true);
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js

@@ -30 +30 @@
 WebInspector.ConsoleCommandView = class ConsoleCommandView extends WebInspector.Object
 {
-    constructor(commandText)
+    constructor(commandText, className)
     {
         super();
@@ -39 +39 @@
         this._element.classList.add("console-user-command");
         this._element.setAttribute("data-labelprefix", WebInspector.UIString("Input: "));
+
+        if (className)
+            this._element.classList.add(className);
 
         this._formattedCommandElement = this._element.appendChild(document.createElement("span"));

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css

@@ -30 +30 @@
 }
 
+.console-user-command.special-user-log > .console-message-text {
+    padding: 1px 6px;
+    border-radius: 3px;
+    border: 1px solid transparent;
+    background-color: rgb(34, 131, 246);
+    color: white;
+    font-size: 10px;
+    -webkit-user-select: none;
+}
+
 .console-message .repeat-count {
     display: inline-block;

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js

@@ -513 +513 @@
                     return;
                 var text = WebInspector.UIString("Selected Element");
-                WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, remoteObject);
+                WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, remoteObject, true);
             });
         }

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js

@@ -264 +264 @@
                 WebInspector.quickConsole.prompt.pushHistoryItem(text);
 
-            WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, this._remoteObject);
+            WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, this._remoteObject, isImpossible);
         }.bind(this));
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js

@@ -162 +162 @@
 
         var text = WebInspector.UIString("Selected Symbol");
-        WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, symbol);
+        WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, symbol, true);
     }
 
@@ -178 +178 @@
             WebInspector.quickConsole.prompt.pushHistoryItem(text);
 
-        WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, resolvedValue);
+        WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, resolvedValue, isImpossible);
     }