Changeset 187036 in webkit

Timestamp:

Jul 20, 2015, 2:37:18 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Allow video to rotate when app doesnt allow rotation.
​https://bugs.webkit.org/show_bug.cgi?id=147121

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-07-20
Reviewed by Jer Noble.

Set an SPI bool on the fullscreen video root view controller to allow it to override app rotation restrictions.
This allows video to be played in landscape in portrait only apps.

• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setupFullscreen):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-07-20  Jeremy Jones  <jeremyj@apple.com>
+
+        Allow video to rotate when app doesnt allow rotation.
+        https://bugs.webkit.org/show_bug.cgi?id=147121
+
+        Reviewed by Jer Noble.
+
+        Set an SPI bool on the fullscreen video root view controller to allow it to override app rotation restrictions. 
+        This allows video to be played in landscape in portrait only apps.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (WebVideoFullscreenInterfaceAVKit::setupFullscreen):
+
 2015-07-20  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm

@@ -898 +898 @@
 @end
 
+@interface UIViewController ()
+@property (nonatomic, assign, setter=_setIgnoreAppSupportedOrientations:) BOOL _ignoreAppSupportedOrientations;
+@end
+
 void WebVideoFullscreenInterfaceAVKit::setupFullscreen(PlatformLayer& videoLayer, const WebCore::IntRect& initialRect, UIView* parentView, HTMLMediaElementEnums::VideoFullscreenMode mode, bool allowsPictureInPicturePlayback)
 {
@@ -917 +921 @@
         m_viewController = adoptNS([allocUIViewControllerInstance() init]);
         [[m_viewController view] setFrame:[m_window bounds]];
+        [m_viewController _setIgnoreAppSupportedOrientations:YES];
         [m_window setRootViewController:m_viewController.get()];
         [m_window makeKeyAndVisible];