Changeset 187210 in webkit

Timestamp:

Jul 22, 2015 9:24:12 PM (9 years ago)

Author:

Wenson Hsieh

Message:

Coordinates-based snap offsets don't update correctly when container is scrolled
​https://bugs.webkit.org/show_bug.cgi?id=147215

Reviewed by Brent Fulgham.

Source/WebCore:

Fixes the way we append the snap offsets of child elements with coordinates. We
now consider the scroll offset of the parent scroll snapping container, so snap
offset recomputations don't fail on scroll snapping containers.

Test: css3/scroll-snap/scroll-snap-coordinate-overflow-resize.html

• page/scrolling/AxisScrollSnapOffsets.cpp:

(WebCore::appendChildSnapOffsets): Fixed to consider the scroll offset of the

parent container.

LayoutTests:

Tests that snap offsets update properly on scrolled containers.

• css3/scroll-snap/scroll-snap-coordinate-overflow-resize-expected.txt: Added.
• css3/scroll-snap/scroll-snap-coordinate-overflow-resize.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/scroll-snap/scroll-snap-coordinate-overflow-resize-expected.txt (added)
• LayoutTests/css3/scroll-snap/scroll-snap-coordinate-overflow-resize.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Coordinates-based snap offsets don't update correctly when container is scrolled
+        https://bugs.webkit.org/show_bug.cgi?id=147215
+
+        Reviewed by Brent Fulgham.
+
+        Tests that snap offsets update properly on scrolled containers.
+
+        * css3/scroll-snap/scroll-snap-coordinate-overflow-resize-expected.txt: Added.
+        * css3/scroll-snap/scroll-snap-coordinate-overflow-resize.html: Added.
+
 2015-07-22  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Coordinates-based snap offsets don't update correctly when container is scrolled
+        https://bugs.webkit.org/show_bug.cgi?id=147215
+
+        Reviewed by Brent Fulgham.
+
+        Fixes the way we append the snap offsets of child elements with coordinates. We
+        now consider the scroll offset of the parent scroll snapping container, so snap
+        offset recomputations don't fail on scroll snapping containers.
+
+        Test: css3/scroll-snap/scroll-snap-coordinate-overflow-resize.html
+
+        * page/scrolling/AxisScrollSnapOffsets.cpp:
+        (WebCore::appendChildSnapOffsets): Fixed to consider the scroll offset of the
+            parent container.
+
 2015-07-22  Matthew Daiter  <mdaiter@apple.com>
 

trunk/Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp

@@ -61 +61 @@
         
         LayoutRect viewSize = box->contentBoxRect();
-        FloatPoint position = box->localToContainerPoint(FloatPoint(), parent.renderBox());
+        FloatPoint position = box->localToContainerPoint(FloatPoint(parent.renderBox()->scrollLeft(), parent.renderBox()->scrollTop()), parent.renderBox());
         for (auto& coordinate : scrollSnapCoordinates) {
             LayoutUnit lastPotentialSnapPositionX = position.x() + valueForLength(coordinate.width(), viewSize.width());