Changeset 187700 in webkit

Timestamp:

Jul 31, 2015 6:32:02 PM (9 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Scrolling "jumps" in console
​https://bugs.webkit.org/show_bug.cgi?id=147482

Reviewed by Joseph Pecoraro.

Removed focus call on messageElement.

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._mousedown): Deleted.
(WebInspector.LogContentView.prototype._didFocus): Deleted.
(WebInspector.LogContentView.prototype._didBlur): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/LogContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-07-31  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Scrolling "jumps" in console
+        https://bugs.webkit.org/show_bug.cgi?id=147482
+
+        Reviewed by Joseph Pecoraro.
+
+        Removed focus call on messageElement.
+
+        * UserInterface/Views/LogContentView.js:
+        (WebInspector.LogContentView):
+        (WebInspector.LogContentView.prototype._mousedown): Deleted.
+        (WebInspector.LogContentView.prototype._didFocus): Deleted.
+        (WebInspector.LogContentView.prototype._didBlur): Deleted.
+
 2015-07-31  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

@@ -43 +43 @@
     this.messagesElement.setAttribute("role", "log");
     this.messagesElement.addEventListener("mousedown", this._mousedown.bind(this));
-    this.messagesElement.addEventListener("focus", this._didFocus.bind(this));
-    this.messagesElement.addEventListener("blur", this._didBlur.bind(this));
     this.messagesElement.addEventListener("keydown", this._keyDown.bind(this));
     this.messagesElement.addEventListener("dragstart", this._ondragstart.bind(this), true);
@@ -410 +408 @@
         }
 
-        if (!this._focused)
-            this.messagesElement.focus();
-
         this._mouseDownWrapper = event.target.enclosingNodeOrSelfWithClass(WebInspector.LogContentView.ItemWrapperStyleClassName);
         this._mouseDownShiftKey = event.shiftKey;
@@ -731 +726 @@
 
         this._performSearch();
-    },
-
-    _didFocus: function(event)
-    {
-        this._focused = true;
-    },
-
-    _didBlur: function(event)
-    {
-        this._focused = false;
     },