Changeset 188401 in webkit

Timestamp:

Aug 13, 2015 2:06:46 PM (9 years ago)

Author:

ggaren@apple.com

Message:

Periodic code deletion should delete RegExp code
​https://bugs.webkit.org/show_bug.cgi?id=147990

Reviewed by Filip Pizlo.

The RegExp code cache was created for the sake of simple loops that
re-created the same RegExps. It's reasonable to delete it periodically.

• heap/Heap.cpp:

(JSC::Heap::deleteOldCode):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/Heap.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-08-13  Geoffrey Garen  <ggaren@apple.com>
+
+        Periodic code deletion should delete RegExp code
+        https://bugs.webkit.org/show_bug.cgi?id=147990
+
+        Reviewed by Filip Pizlo.
+
+        The RegExp code cache was created for the sake of simple loops that
+        re-created the same RegExps. It's reasonable to delete it periodically.
+
+        * heap/Heap.cpp:
+        (JSC::Heap::deleteOldCode):
+
 2015-08-13  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/JavaScriptCore/heap/Heap.cpp

@@ -44 +44 @@
 #include "JSVirtualMachineInternal.h"
 #include "RecursiveAllocationScope.h"
+#include "RegExpCache.h"
 #include "Tracing.h"
 #include "TypeProfilerLog.h"
@@ -1144 +1145 @@
     GCPHASE(DeleteOldCode);
     if (gcStartTime - m_lastCodeDiscardTime > minute) {
+        m_vm->regExpCache()->deleteAllCode();
         deleteAllCompiledCode();
         m_lastCodeDiscardTime = WTF::monotonicallyIncreasingTime();