Changeset 188570 in webkit

Timestamp:

Aug 17, 2015 9:08:47 PM (9 years ago)

Author:

Devin Rousso

Message:

Web Inspector: web fonts or unknown fonts show up as Times in visual sidebar
​https://bugs.webkit.org/show_bug.cgi?id=148103

Reviewed by Timothy Hatcher.

• UserInterface/Views/VisualStyleFontFamilyTreeElement.js:

(WebInspector.VisualStyleFontFamilyTreeElement.prototype.updateMainTitle):
Fonts now fall back to sans-serif and -apple-system if they do not exist.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/VisualStyleFontFamilyTreeElement.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-08-17  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: web fonts or unknown fonts show up as Times in visual sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=148103
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/VisualStyleFontFamilyTreeElement.js:
+        (WebInspector.VisualStyleFontFamilyTreeElement.prototype.updateMainTitle):
+        Fonts now fall back to sans-serif and -apple-system if they do not exist.
+
 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleFontFamilyTreeElement.js

@@ -52 +52 @@
     updateMainTitle(text)
     {
-        this.mainTitle = this._listItemNode.style.fontFamily = this._keywordEditor.value = text;
+        this.mainTitle = this._keywordEditor.value = text;
+        this._listItemNode.style.fontFamily = text + ", " + WebInspector.VisualStyleFontFamilyTreeElement.FontFamilyFallback;
 
         let hasText = text && text.length;
@@ -161 +162 @@
 };
 
+WebInspector.VisualStyleFontFamilyTreeElement.FontFamilyFallback = "-apple-system, sans-serif";
+
 WebInspector.VisualStyleFontFamilyTreeElement.Event = {
     KeywordChanged: "visual-style-font-family-tree-element-keyword-changed",