Changeset 188698 in webkit

Timestamp:

Aug 20, 2015 1:53:26 PM (9 years ago)

Author:

Chris Dumez

Message:

REGRESSION: http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=148205

Unreviewed, give the disk cache a chance to settle down before querying
the resource again. This fixes the flakiness locally. Longer term, I will
try and figure out why the cache is sometimes revalidating if the resource
is requested very quickly after.

• http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-08-20  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION: http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html is very flaky
+        https://bugs.webkit.org/show_bug.cgi?id=148205
+
+        Unreviewed, give the disk cache a chance to settle down before querying
+        the resource again. This fixes the flakiness locally. Longer term, I will
+        try and figure out why the cache is sometimes revalidating if the resource
+        is requested very quickly after.
+
+        * http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html:
+
 2015-08-11  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html

@@ -14 +14 @@
 
 runTests(tests, function() {
-    debug("304 response included an 'Expires' header in the future, so we should not need to revalidate this time.");
-    runTests(tests);
+    // Wait for things to settle down in the cache.
+    setTimeout(function() {
+        debug("304 response included an 'Expires' header in the future, so we should not need to revalidate this time.");
+        runTests(tests);
+    }, 200);
 });