Changeset 188802 in webkit

Timestamp:

Aug 21, 2015, 4:50:21 PM (11 years ago)

Author:

mmaxfield@apple.com

Message:

[OS X] Remove dead code from FontCache::systemFallbackForCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=148218

Reviewed by Daniel Bates.

lookupCTFont() in FontCacheMac.mm will always return the best font (because
CTFontCreateForCharactersWithLanguage() does so). Also, all fonts that will
be created on WebKit's behalf are already printer fonts.

No new tests because there is no behavior change.

• platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::systemFallbackForCharacters): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/mac/FontCacheMac.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [OS X] Remove dead code from FontCache::systemFallbackForCharacters()
+        https://bugs.webkit.org/show_bug.cgi?id=148218
+
+        Reviewed by Daniel Bates.
+
+        lookupCTFont() in FontCacheMac.mm will always return the best font (because
+        CTFontCreateForCharactersWithLanguage() does so). Also, all fonts that will
+        be created on WebKit's behalf are already printer fonts.
+
+        No new tests because there is no behavior change.
+
+        * platform/graphics/mac/FontCacheMac.mm:
+        (WebCore::FontCache::systemFallbackForCharacters): Deleted.
+
 2015-08-21  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm

@@ -519 +519 @@
     NSFont *substituteFont = toNSFont(fallbackDedupSet().add(result).iterator->get());
 
-    // Use the family name from the AppKit-supplied substitute font, requesting the
-    // traits, weight, and size we want. One way this does better than the original
-    // AppKit request is that it takes synthetic bold and oblique into account.
-    // But it does create the possibility that we could end up with a font that
-    // doesn't actually cover the characters we need.
-
     NSFontManager *fontManager = [NSFontManager sharedFontManager];
 
     NSFontTraitMask traits = 0;
     NSInteger weight;
-    CGFloat size;
 
     if (nsFont) {
@@ -539 +532 @@
             traits |= NSFontItalicTrait;
         weight = [fontManager weightOfFont:nsFont];
-        size = [nsFont pointSize];
     } else {
-        // For custom fonts nsFont is nil.
+        ASSERT(!CORETEXT_WEB_FONTS);
         traits = description.italic() ? NSFontItalicTrait : 0;
         weight = toAppKitFontWeight(description.weight());
-        size = description.computedPixelSize();
     }
 
     NSFontTraitMask substituteFontTraits = [fontManager traitsOfFont:substituteFont];
     NSInteger substituteFontWeight = [fontManager weightOfFont:substituteFont];
-
-    if (traits != substituteFontTraits || weight != substituteFontWeight || !nsFont) {
-        if (NSFont *bestVariation = [fontManager fontWithFamily:[substituteFont familyName] traits:traits weight:weight size:size]) {
-            UChar32 character;
-            U16_GET(characters, 0, 0, length, character);
-            if (!nsFont || (([fontManager traitsOfFont:bestVariation] != substituteFontTraits || [fontManager weightOfFont:bestVariation] != substituteFontWeight)
-                && [[bestVariation coveredCharacterSet] longCharacterIsMember:character]))
-                substituteFont = bestVariation;
-        }
-    }
-
-    substituteFont = [substituteFont printerFont];
-
-    substituteFontTraits = [fontManager traitsOfFont:substituteFont];
-    substituteFontWeight = [fontManager weightOfFont:substituteFont];
 
     FontPlatformData alternateFont(toCTFont(substituteFont), platformData.size(),