Changeset 188945 in webkit

Timestamp:

Aug 25, 2015 10:47:59 PM (9 years ago)

Author:

Gyuyoung Kim

Message:

Remove python tests for PassRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=148463

Reviewed by Andy Estes.

As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(PassPtrTest): Deleted.
(PassPtrTest.assert_pass_ptr_check): Deleted.
(PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
(PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
(PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
(PassPtrTest.test_ref_ptr_parameter_value): Deleted.
(PassPtrTest.test_ref_ptr_member_variable): Deleted.
(PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
+
+        Remove python tests for PassRefPtr 
+        https://bugs.webkit.org/show_bug.cgi?id=148463
+
+        Reviewed by Andy Estes.
+
+        As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
+
+        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+        (PassPtrTest): Deleted.
+        (PassPtrTest.assert_pass_ptr_check): Deleted.
+        (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
+        (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
+        (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
+        (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
+        (PassPtrTest.test_ref_ptr_member_variable): Deleted.
+        (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
+
 2015-08-25  Andy Estes  <aestes@apple.com>
 

trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

@@ -3618 +3618 @@
 
 
-class PassPtrTest(CppStyleTestBase):
-    # For http://webkit.org/coding/RefPtr.html
-
-    def assert_pass_ptr_check(self, code, expected_message):
-        """Check warnings for Pass*Ptr are as expected.
-
-        Args:
-          code: C++ source code expected to generate a warning message.
-          expected_message: Message expected to be generated by the C++ code.
-        """
-        self.assertEqual(expected_message,
-                          self.perform_pass_ptr_check(code))
-
-    def test_pass_ref_ptr_in_function(self):
-        self.assert_pass_ptr_check(
-            'int myFunction()\n'
-            '{\n'
-            '    PassRefPtr<Type1> variable = variable2;\n'
-            '}',
-            'Local variables should never be PassRefPtr (see '
-            'http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]')
-
-    def test_pass_other_type_ptr_in_function(self):
-        self.assert_pass_ptr_check(
-            'int myFunction()\n'
-            '{\n'
-            '    PassOtherTypePtr<Type1> variable;\n'
-            '}',
-            'Local variables should never be PassOtherTypePtr (see '
-            'http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]')
-
-    def test_pass_ref_ptr_return_value(self):
-        self.assert_pass_ptr_check(
-            'PassRefPtr<Type1>\n'
-            'myFunction(int)\n'
-            '{\n'
-            '}',
-            '')
-        self.assert_pass_ptr_check(
-            'PassRefPtr<Type1> myFunction(int)\n'
-            '{\n'
-            '}',
-            '')
-        self.assert_pass_ptr_check(
-            'PassRefPtr<Type1> myFunction();\n',
-            '')
-        self.assert_pass_ptr_check(
-            'RefPtr<Type1> myFunction(int)\n'
-            '{\n'
-            '}',
-            '')
-
-    def test_ref_ptr_parameter_value(self):
-        self.assert_pass_ptr_check(
-            'int myFunction(PassRefPtr<Type1>)\n'
-            '{\n'
-            '}',
-            '')
-        self.assert_pass_ptr_check(
-            'int myFunction(RefPtr<Type1>)\n'
-            '{\n'
-            '}',
-            'The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]')
-        self.assert_pass_ptr_check(
-            'int myFunction(RefPtr<Type1>&)\n'
-            '{\n'
-            '}',
-            '')
-        self.assert_pass_ptr_check(
-            'int myFunction(RefPtr<Type1>*)\n'
-            '{\n'
-            '}',
-            '')
-
-    def test_ref_ptr_member_variable(self):
-        self.assert_pass_ptr_check(
-            'class Foo {'
-            '    RefPtr<Type1> m_other;\n'
-            '};\n',
-            '')
-
-
 class LeakyPatternTest(CppStyleTestBase):