Changeset 189690 in webkit

Timestamp:

Sep 14, 2015 1:05:24 AM (9 years ago)

Author:

Carlos Garcia Campos

Message:

Merge r188672 - Select validation does not correctly work when handling change event
​https://bugs.webkit.org/show_bug.cgi?id=145869

Reviewed by Dean Jackson.

Source/WebCore:

When selecting an option in a <select> with validation that also has an onchange listener, calling
checkValidity() for the select within the onchange handler would produce incorrect results and (on
a debug build) crash at an assertion. This is because the change events were being dispatched before
form validity was updated. Making the validation step come before the change event dispatch fixes
this issue.

Test: fast/forms/onchange-select-check-validity.html

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectOption): Update validity before dispatching change events.

LayoutTests:

Tests that checkValidity() returns correct results from within the onchange handler of a
<select> when the validity of the selected option changes.

• fast/forms/onchange-select-check-validity-expected.txt: Added.
• fast/forms/onchange-select-check-validity.html: Added.

Location:

releases/WebKitGTK/webkit-2.10

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/onchange-select-check-validity-expected.txt (added)
• LayoutTests/fast/forms/onchange-select-check-validity.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLSelectElement.cpp (modified) (2 diffs)

releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog

@@ +1 @@
+2015-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Select validation does not correctly work when handling change event
+        https://bugs.webkit.org/show_bug.cgi?id=145869
+
+        Reviewed by Dean Jackson.
+
+        Tests that checkValidity() returns correct results from within the onchange handler of a
+        <select> when the validity of the selected option changes.
+
+        * fast/forms/onchange-select-check-validity-expected.txt: Added.
+        * fast/forms/onchange-select-check-validity.html: Added.
+
 2015-08-19  Jinyoung Hur  <hur.ims@navercorp.com>
 

releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog

@@ +1 @@
+2015-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Select validation does not correctly work when handling change event
+        https://bugs.webkit.org/show_bug.cgi?id=145869
+
+        Reviewed by Dean Jackson.
+
+        When selecting an option in a <select> with validation that also has an onchange listener, calling
+        checkValidity() for the select within the onchange handler would produce incorrect results and (on
+        a debug build) crash at an assertion. This is because the change events were being dispatched before
+        form validity was updated. Making the validation step come before the change event dispatch fixes
+        this issue.
+
+        Test: fast/forms/onchange-select-check-validity.html
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::selectOption): Update validity before dispatching change events.
+
 2015-08-19  Jinyoung Hur  <hur.ims@navercorp.com>
 

releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLSelectElement.cpp

@@ -900 +900 @@
     scrollToSelection();
 
+    updateValidity();
     if (usesMenuList()) {
         m_isProcessingUserDrivenChange = flags & UserDriven;
@@ -911 +912 @@
         }
     }
-
-    updateValidity();
 }