Changeset 190342 in webkit

Timestamp:

Sep 29, 2015 10:58:38 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc)
​https://bugs.webkit.org/show_bug.cgi?id=149649

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-29
Reviewed by Darin Adler.

• UserInterface/Base/Utilities.js:

(value):
Since keySets in this instance are often used as hash maps with the
in operator, create a blank object that won't have Object.prototype
functions that would be seen by in.

• UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

(WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare):
Sort defineGetter and lookupGetter and friends last, since they
are rarely used properties.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Utilities.js (modified) (1 diff)
• UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-09-29  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc)
+        https://bugs.webkit.org/show_bug.cgi?id=149649
+
+        Reviewed by Darin Adler.
+
+        * UserInterface/Base/Utilities.js:
+        (value):
+        Since keySets in this instance are often used as hash maps with the
+        `in` operator, create a blank object that won't have Object.prototype
+        functions that would be seen by `in`.
+
+        * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
+        (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare):
+        Sort __defineGetter__ and __lookupGetter__ and friends last, since they
+        are rarely used properties.
+
 2015-09-29  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js

@@ -446 +446 @@
     value: function()
     {
-        var keys = {};
+        let keys = Object.create(null);
         for (var i = 0; i < this.length; ++i)
             keys[this[i]] = true;

trunk/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js

@@ -264 +264 @@
             {
                 // Try to sort in numerical order first.
-                var numericCompareResult = a - b;
+                let numericCompareResult = a - b;
                 if (!isNaN(numericCompareResult))
                     return numericCompareResult;
+
+                // Sort __defineGetter__, __lookupGetter__, and friends last.
+                let aRareProperty = a.startsWith("__") && a.endsWith("__");
+                let bRareProperty = b.startsWith("__") && b.endsWith("__");
+                if (aRareProperty && !bRareProperty)
+                    return 1;
+                if (!aRareProperty && bRareProperty)
+                    return -1;
 
                 // Not numbers, sort as strings.