Changeset 190610 in webkit

Timestamp:

Oct 6, 2015 1:02:00 AM (9 years ago)

Author:

calvaris@igalia.com

Message:

JSBuiltinConstructor must always add builtin header
​https://bugs.webkit.org/show_bug.cgi?id=149759

Reviewed by Darin Adler.

Covered by TestJSBuiltinConstructor.idl.

• bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForJSBuiltinMethods): Forces adding the builtin header when the JSBuiltinConstructor is present.

• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp: Expectation.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (1 diff)
• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-10-06  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        JSBuiltinConstructor must always add builtin header
+        https://bugs.webkit.org/show_bug.cgi?id=149759
+
+        Reviewed by Darin Adler.
+
+        Covered by TestJSBuiltinConstructor.idl.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (AddIncludesForJSBuiltinMethods): Forces adding the builtin header when the JSBuiltinConstructor is present.
+        * bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp: Expectation.
+
 2015-10-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -5116 +5116 @@
     my $interface = shift;
 
+    if ($interface->extendedAttributes->{"JSBuiltinConstructor"}) {
+        AddToImplIncludes($interface->name . "Builtins.h");
+        return 1;
+    }
+
     foreach my $function (@{$interface->functions}) {
         next unless ($function->signature->extendedAttributes->{"JSBuiltin"});

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp

@@ -23 +23 @@
 
 #include "JSDOMBinding.h"
+#include "TestJSBuiltinConstructorBuiltins.h"
 #include <wtf/GetPtr.h>