Changeset 190628 in webkit

Timestamp:

Oct 6, 2015 11:20:29 AM (9 years ago)

Author:

timothy_horton@apple.com

Message:

Tile map shows a green rect when threaded scrolling is disabled
​https://bugs.webkit.org/show_bug.cgi?id=149716

Reviewed by Darin Adler.

Green is supposed to indicate that we're using the fast path; if threaded
scrolling is disabled, we're definitely not doing that.

• platform/graphics/TiledBacking.h:
• platform/graphics/ca/TileController.cpp:

(WebCore::TileController::TileController):

• platform/graphics/ca/TileCoverageMap.cpp:

(WebCore::TileCoverageMap::update):
Default to the "we have no ScrollingCoordinator" purple indication;
if a ScrollingCoordinator comes along it will setScrollingModeIndication
and change it from this default.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/TiledBacking.h (modified) (1 diff)
• platform/graphics/ca/TileController.cpp (modified) (1 diff)
• platform/graphics/ca/TileCoverageMap.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-10-06  Tim Horton  <timothy_horton@apple.com>
+
+        Tile map shows a green rect when threaded scrolling is disabled
+        https://bugs.webkit.org/show_bug.cgi?id=149716
+
+        Reviewed by Darin Adler.
+
+        Green is supposed to indicate that we're using the fast path; if threaded
+        scrolling is disabled, we're definitely not doing that.
+
+        * platform/graphics/TiledBacking.h:
+        * platform/graphics/ca/TileController.cpp:
+        (WebCore::TileController::TileController):
+        * platform/graphics/ca/TileCoverageMap.cpp:
+        (WebCore::TileCoverageMap::update):
+        Default to the "we have no ScrollingCoordinator" purple indication;
+        if a ScrollingCoordinator comes along it will setScrollingModeIndication
+        and change it from this default.
+
 2015-10-06  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/graphics/TiledBacking.h

@@ -36 +36 @@
 
 enum ScrollingModeIndication {
+    SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication,
     SynchronousScrollingBecauseOfStyleIndication,
     SynchronousScrollingBecauseOfEventHandlersIndication,

trunk/Source/WebCore/platform/graphics/ca/TileController.cpp

@@ -71 +71 @@
     , m_hasTilesWithTemporaryScaleFactor(false)
     , m_tileDebugBorderWidth(0)
-    , m_indicatorMode(AsyncScrollingIndication)
+    , m_indicatorMode(SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication)
     , m_topContentInset(0)
 {

trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp

@@ -102 +102 @@
     Color visibleRectIndicatorColor;
     switch (m_controller.indicatorMode()) {
+    case SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication:
+        visibleRectIndicatorColor = Color(200, 80, 255);
+        break;
     case SynchronousScrollingBecauseOfStyleIndication:
         visibleRectIndicatorColor = Color(255, 0, 0);