Changeset 191459 in webkit
- Timestamp:
- Oct 22, 2015 11:35:55 AM (9 years ago)
- Location:
- branches/safari-601.1.46-branch
- Files:
-
- 3 deleted
- 24 edited
Legend:
- Unmodified
- Added
- Removed
-
branches/safari-601.1.46-branch/LayoutTests/ChangeLog
r191458 r191459 1 2015-10-20 Matthew Hanson <matthew_hanson@apple.com> 2 3 Merge r191063. rdar://problem/22900764 4 5 2015-10-14 Alex Christensen <achristensen@webkit.org> 6 7 Add SPI for reloading without content blockers 8 https://bugs.webkit.org/show_bug.cgi?id=150058 9 rdar://problem/22742222 10 11 Reviewed by Sam Weinig. 12 13 * http/tests/contentextensions/disable-blocker-expected.txt: Removed. 14 * http/tests/contentextensions/disable-blocker.html: Removed. 15 * http/tests/contentextensions/disable-blocker.html.json: Removed. 16 _userContentExtensionsEnabled is going to be removed, and its functionality is what this test tested. 17 1 18 2015-10-20 Matthew Hanson <matthew_hanson@apple.com> 2 19 -
branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
r191458 r191459 1 2015-10-20 Matthew Hanson <matthew_hanson@apple.com> 2 3 Merge r191063. rdar://problem/22900764 4 5 2015-10-14 Alex Christensen <achristensen@webkit.org> 6 7 Add SPI for reloading without content blockers 8 https://bugs.webkit.org/show_bug.cgi?id=150058 9 rdar://problem/22742222 10 11 Reviewed by Sam Weinig. 12 13 * loader/FrameLoader.cpp: 14 (WebCore::FrameLoader::reloadWithOverrideEncoding): 15 (WebCore::FrameLoader::reload): 16 * loader/FrameLoader.h: 17 * page/Page.h: 18 (WebCore::Page::userContentController): 19 (WebCore::Page::userContentExtensionsEnabled): Deleted. 20 (WebCore::Page::setUserContentExtensionsEnabled): Deleted. 21 * replay/UserInputBridge.cpp: 22 (WebCore::UserInputBridge::loadRequest): 23 (WebCore::UserInputBridge::reloadFrame): 24 (WebCore::UserInputBridge::stopLoadingFrame): 25 * replay/UserInputBridge.h: 26 Pass a bool from the reloadWithoutContentBlockers call to the DocumentLoader, 27 which stores the state of whether the content blockers are enabled or not. 28 Remove the state from the Page and copying the state from the Page to the DocumentLoader 29 because that caused issues with the content blockers being re-enabled at the wrong time. 30 1 31 2015-10-20 Matthew Hanson <matthew_hanson@apple.com> 2 32 -
branches/safari-601.1.46-branch/Source/WebCore/loader/FrameLoader.cpp
r191458 r191459 1565 1565 } 1566 1566 1567 void FrameLoader::reload(bool endToEndReload )1567 void FrameLoader::reload(bool endToEndReload, bool contentBlockersEnabled) 1568 1568 { 1569 1569 if (!m_documentLoader) … … 1586 1586 applyShouldOpenExternalURLsPolicyToNewDocumentLoader(*loader, m_documentLoader->shouldOpenExternalURLsPolicyToPropagate()); 1587 1587 1588 loader->setUserContentExtensionsEnabled(contentBlockersEnabled); 1589 1588 1590 ResourceRequest& request = loader->request(); 1589 1591 -
branches/safari-601.1.46-branch/Source/WebCore/loader/FrameLoader.h
r186005 r191459 124 124 void submitForm(PassRefPtr<FormSubmission>); 125 125 126 WEBCORE_EXPORT void reload(bool endToEndReload = false );126 WEBCORE_EXPORT void reload(bool endToEndReload = false, bool contentBlockersEnabled = true); 127 127 WEBCORE_EXPORT void reloadWithOverrideEncoding(const String& overrideEncoding); 128 128 -
branches/safari-601.1.46-branch/Source/WebCore/page/Page.h
r187421 r191459 425 425 WEBCORE_EXPORT void setUserContentController(UserContentController*); 426 426 427 bool userContentExtensionsEnabled() const { return m_userContentExtensionsEnabled; }428 void setUserContentExtensionsEnabled(bool enabled) { m_userContentExtensionsEnabled = enabled; }429 430 427 VisitedLinkStore& visitedLinkStore(); 431 428 WEBCORE_EXPORT void setVisitedLinkStore(Ref<VisitedLinkStore>&&); … … 624 621 MediaProducer::MediaStateFlags m_mediaState { MediaProducer::IsNotPlaying }; 625 622 626 bool m_userContentExtensionsEnabled { true };627 623 bool m_allowsMediaDocumentInlinePlayback { false }; 628 624 }; -
branches/safari-601.1.46-branch/Source/WebCore/replay/UserInputBridge.cpp
r182963 r191459 243 243 } 244 244 245 void UserInputBridge::reloadFrame(Frame* frame, bool endToEndReload, InputSource)246 { 247 frame->loader().reload(endToEndReload );245 void UserInputBridge::reloadFrame(Frame* frame, bool endToEndReload, bool contentBlockersEnabled, InputSource) 246 { 247 frame->loader().reload(endToEndReload, contentBlockersEnabled); 248 248 } 249 249 -
branches/safari-601.1.46-branch/Source/WebCore/replay/UserInputBridge.h
r182963 r191459 90 90 // Navigation APIs. 91 91 WEBCORE_EXPORT void loadRequest(const FrameLoadRequest&, InputSource source = InputSource::User); 92 WEBCORE_EXPORT void reloadFrame(Frame*, bool endToEndReload, InputSource source = InputSource::User);92 WEBCORE_EXPORT void reloadFrame(Frame*, bool endToEndReload, bool contentBlockersEnabled, InputSource = InputSource::User); 93 93 WEBCORE_EXPORT void stopLoadingFrame(Frame*, InputSource source = InputSource::User); 94 94 WEBCORE_EXPORT bool tryClosePage(InputSource source = InputSource::User); -
branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
r191458 r191459 1 2015-10-20 Matthew Hanson <matthew_hanson@apple.com> 2 3 Merge r191063. rdar://problem/22900764 4 5 2015-10-14 Alex Christensen <achristensen@webkit.org> 6 7 Add SPI for reloading without content blockers 8 https://bugs.webkit.org/show_bug.cgi?id=150058 9 rdar://problem/22742222 10 11 Reviewed by Sam Weinig. 12 13 * Shared/WebPageCreationParameters.cpp: 14 (WebKit::WebPageCreationParameters::encode): 15 (WebKit::WebPageCreationParameters::decode): 16 * Shared/WebPageCreationParameters.h: 17 * UIProcess/API/C/WKPage.cpp: 18 (WKPageReload): 19 (WKPageReloadWithoutContentBlockers): 20 (WKPageReloadFromOrigin): 21 (WKPageTryClose): 22 (WKPageSetUserContentExtensionsEnabled): 23 (WKPageSupportsTextEncoding): 24 * UIProcess/API/C/WKPage.h: 25 * UIProcess/API/Cocoa/WKBrowsingContextController.mm: 26 (-[WKBrowsingContextController reload]): 27 (-[WKBrowsingContextController reloadFromOrigin]): 28 (-[WKBrowsingContextController applicationNameForUserAgent]): 29 * UIProcess/API/Cocoa/WKWebView.mm: 30 (-[WKWebView reload]): 31 (-[WKWebView reloadFromOrigin]): 32 (-[WKWebView _setUserContentExtensionsEnabled:]): 33 (-[WKWebView _userContentExtensionsEnabled]): 34 (-[WKWebView _webProcessIdentifier]): 35 (-[WKWebView _killWebContentProcess]): 36 (-[WKWebView _reloadWithoutContentBlockers]): 37 (-[WKWebView _killWebContentProcessAndResetState]): 38 * UIProcess/API/Cocoa/WKWebViewPrivate.h: 39 * UIProcess/API/gtk/WebKitWebView.cpp: 40 (webkit_web_view_reload): 41 (webkit_web_view_reload_bypass_cache): 42 * UIProcess/WebFrameProxy.cpp: 43 (WebKit::WebFrameProxy::didHandleContentFilterUnblockNavigation): 44 * UIProcess/WebPageProxy.cpp: 45 (WebKit::WebPageProxy::stopLoading): 46 (WebKit::WebPageProxy::reload): 47 (WebKit::WebPageProxy::creationParameters): 48 (WebKit::WebPageProxy::setShouldScaleViewToFitDocument): 49 (WebKit::WebPageProxy::setUserContentExtensionsEnabled): Deleted. 50 * UIProcess/WebPageProxy.h: 51 (WebKit::WebPageProxy::userContentExtensionsEnabled): Deleted. 52 * WebProcess/WebPage/WebPage.cpp: 53 (WebKit::m_shouldDispatchFakeMouseMoveEvents): 54 (WebKit::WebPage::setDefersLoading): 55 (WebKit::WebPage::reload): 56 (WebKit::WebPage::goForward): 57 (WebKit::WebPage::createDocumentLoader): 58 (WebKit::WebPage::setShouldScaleViewToFitDocument): 59 (WebKit::WebPage::imageOrMediaDocumentSizeChanged): 60 (WebKit::WebPage::setUserContentExtensionsEnabled): Deleted. 61 * WebProcess/WebPage/WebPage.h: 62 * WebProcess/WebPage/WebPage.messages.in: 63 1 64 2015-10-20 Matthew Hanson <matthew_hanson@apple.com> 2 65 -
branches/safari-601.1.46-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp
r185840 r191459 85 85 encoder << appleMailPaginationQuirkEnabled; 86 86 encoder << shouldScaleViewToFitDocument; 87 encoder << userContentExtensionsEnabled;88 87 } 89 88 … … 190 189 return false; 191 190 192 if (!decoder.decode(parameters.userContentExtensionsEnabled))193 return false;194 195 191 return true; 196 192 } -
branches/safari-601.1.46-branch/Source/WebKit2/Shared/WebPageCreationParameters.h
r185840 r191459 131 131 bool appleMailPaginationQuirkEnabled; 132 132 bool shouldScaleViewToFitDocument; 133 bool userContentExtensionsEnabled;134 133 }; 135 134 -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/C/WKPage.cpp
r186538 r191459 221 221 void WKPageReload(WKPageRef pageRef) 222 222 { 223 toImpl(pageRef)->reload(false); 223 const bool reloadFromOrigin = false; 224 const bool contentBlockersEnabled = true; 225 toImpl(pageRef)->reload(reloadFromOrigin, contentBlockersEnabled); 226 } 227 228 void WKPageReloadWithoutContentBlockers(WKPageRef pageRef) 229 { 230 const bool reloadFromOrigin = false; 231 const bool contentBlockersEnabled = false; 232 toImpl(pageRef)->reload(reloadFromOrigin, contentBlockersEnabled); 224 233 } 225 234 226 235 void WKPageReloadFromOrigin(WKPageRef pageRef) 227 236 { 228 toImpl(pageRef)->reload(true); 237 const bool reloadFromOrigin = true; 238 const bool contentBlockersEnabled = true; 239 toImpl(pageRef)->reload(reloadFromOrigin, contentBlockersEnabled); 229 240 } 230 241 … … 356 367 void WKPageSetUserContentExtensionsEnabled(WKPageRef pageRef, bool enabled) 357 368 { 358 toImpl(pageRef)->setUserContentExtensionsEnabled(enabled);369 // FIXME: Remove this function once it is no longer used. 359 370 } 360 371 -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/C/WKPage.h
r185840 r191459 82 82 WK_EXPORT void WKPageStopLoading(WKPageRef page); 83 83 WK_EXPORT void WKPageReload(WKPageRef page); 84 WK_EXPORT void WKPageReloadWithoutContentBlockers(WKPageRef page); 84 85 WK_EXPORT void WKPageReloadFromOrigin(WKPageRef page); 85 86 -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm
r186464 r191459 263 263 - (void)reload 264 264 { 265 _page->reload(false); 265 const bool reloadFromOrigin = false; 266 const bool contentBlockersEnabled = true; 267 _page->reload(reloadFromOrigin, contentBlockersEnabled); 266 268 } 267 269 268 270 - (void)reloadFromOrigin 269 271 { 270 _page->reload(true); 272 const bool reloadFromOrigin = true; 273 const bool contentBlockersEnabled = true; 274 _page->reload(reloadFromOrigin, contentBlockersEnabled); 271 275 } 272 276 -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
r190473 r191459 562 562 - (WKNavigation *)reload 563 563 { 564 auto navigation = _page->reload(false); 564 const bool reloadFromOrigin = false; 565 const bool contentBlockersEnabled = true; 566 auto navigation = _page->reload(reloadFromOrigin, contentBlockersEnabled); 565 567 if (!navigation) 566 568 return nil; … … 571 573 - (WKNavigation *)reloadFromOrigin 572 574 { 573 auto navigation = _page->reload(true); 575 const bool reloadFromOrigin = true; 576 const bool contentBlockersEnabled = true; 577 auto navigation = _page->reload(reloadFromOrigin, contentBlockersEnabled); 574 578 if (!navigation) 575 579 return nil; … … 2018 2022 - (void)_setUserContentExtensionsEnabled:(BOOL)userContentExtensionsEnabled 2019 2023 { 2020 _page->setUserContentExtensionsEnabled(userContentExtensionsEnabled);2024 // This is kept for binary compatibility with iOS 9. 2021 2025 } 2022 2026 2023 2027 - (BOOL)_userContentExtensionsEnabled 2024 2028 { 2025 return _page->userContentExtensionsEnabled(); 2029 // This is kept for binary compatibility with iOS 9. 2030 return true; 2026 2031 } 2027 2032 … … 2037 2042 2038 2043 _page->process().terminate(); 2044 } 2045 2046 - (WKNavigation *)_reloadWithoutContentBlockers 2047 { 2048 const bool reloadFromOrigin = false; 2049 const bool contentBlockersEnabled = false; 2050 auto navigation = _page->reload(reloadFromOrigin, contentBlockersEnabled); 2051 if (!navigation) 2052 return nil; 2053 2054 return [wrapper(*navigation.release().leakRef()) autorelease]; 2039 2055 } 2040 2056 -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
r187980 r191459 176 176 #endif 177 177 178 - (WKNavigation *)_reloadWithoutContentBlockers WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); 179 178 180 - (void)_killWebContentProcessAndResetState; 179 181 -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
r186229 r191459 2453 2453 g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView)); 2454 2454 2455 getPage(webView)->reload(false); 2455 const bool reloadFromOrigin = false; 2456 const bool contentBlockersEnabled = true; 2457 getPage(webView)->reload(reloadFromOrigin, contentBlockersEnabled); 2456 2458 } 2457 2459 … … 2467 2469 g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView)); 2468 2470 2469 getPage(webView)->reload(true); 2471 const bool reloadFromOrigin = true; 2472 const bool contentBlockersEnabled = true; 2473 getPage(webView)->reload(reloadFromOrigin, contentBlockersEnabled); 2470 2474 } 2471 2475 -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebFrameProxy.cpp
r187390 r191459 247 247 ASSERT(page); 248 248 m_contentFilterUnblockHandler.requestUnblockAsync([page](bool unblocked) { 249 if (unblocked) 250 page->reload(false); 249 if (unblocked) { 250 const bool reloadFromOrigin = false; 251 const bool contentBlockersEnabled = true; 252 page->reload(reloadFromOrigin, contentBlockersEnabled); 253 } 251 254 }); 252 255 return true; -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
r187649 r191459 1040 1040 } 1041 1041 1042 RefPtr<API::Navigation> WebPageProxy::reload(bool reloadFromOrigin )1042 RefPtr<API::Navigation> WebPageProxy::reload(bool reloadFromOrigin, bool contentBlockersEnabled) 1043 1043 { 1044 1044 SandboxExtension::Handle sandboxExtensionHandle; … … 1060 1060 auto navigation = m_navigationState->createReloadNavigation(); 1061 1061 1062 m_process->send(Messages::WebPage::Reload(navigation->navigationID(), reloadFromOrigin, sandboxExtensionHandle), m_pageID);1062 m_process->send(Messages::WebPage::Reload(navigation->navigationID(), reloadFromOrigin, contentBlockersEnabled, sandboxExtensionHandle), m_pageID); 1063 1063 m_process->responsivenessTimer()->start(); 1064 1064 … … 5203 5203 #endif 5204 5204 parameters.shouldScaleViewToFitDocument = m_shouldScaleViewToFitDocument; 5205 parameters.userContentExtensionsEnabled = m_userContentExtensionsEnabled;5206 5205 5207 5206 return parameters; … … 6101 6100 } 6102 6101 6103 void WebPageProxy::setUserContentExtensionsEnabled(bool userContentExtensionsEnabled)6104 {6105 if (m_userContentExtensionsEnabled == userContentExtensionsEnabled)6106 return;6107 6108 m_userContentExtensionsEnabled = userContentExtensionsEnabled;6109 6110 if (!isValid())6111 return;6112 6113 m_process->send(Messages::WebPage::SetUserContentExtensionsEnabled(userContentExtensionsEnabled), m_pageID);6114 }6115 6116 6102 } // namespace WebKit -
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebPageProxy.h
r190797 r191459 377 377 378 378 void stopLoading(); 379 RefPtr<API::Navigation> reload(bool reloadFromOrigin );379 RefPtr<API::Navigation> reload(bool reloadFromOrigin, bool contentBlockersEnabled); 380 380 381 381 RefPtr<API::Navigation> goForward(); … … 671 671 void setShouldScaleViewToFitDocument(bool); 672 672 673 bool userContentExtensionsEnabled() { return m_userContentExtensionsEnabled; }674 void setUserContentExtensionsEnabled(bool);675 676 673 float deviceScaleFactor() const; 677 674 void setIntrinsicDeviceScaleFactor(float); … … 1786 1783 #endif 1787 1784 1788 bool m_userContentExtensionsEnabled { true };1789 1785 }; 1790 1786 -
branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
r191458 r191459 519 519 scaleView(parameters.viewScaleFactor); 520 520 521 m_page->setUserContentExtensionsEnabled(parameters.userContentExtensionsEnabled);522 523 521 #if PLATFORM(IOS) 524 522 m_page->settings().setContentDispositionAttachmentSandboxEnabled(true); … … 1150 1148 } 1151 1149 1152 void WebPage::reload(uint64_t navigationID, bool reloadFromOrigin, const SandboxExtension::Handle& sandboxExtensionHandle)1150 void WebPage::reload(uint64_t navigationID, bool reloadFromOrigin, bool contentBlockersEnabled, const SandboxExtension::Handle& sandboxExtensionHandle) 1153 1151 { 1154 1152 SendStopResponsivenessTimer stopper(this); … … 1158 1156 1159 1157 m_sandboxExtensionTracker.beginLoad(m_mainFrame.get(), sandboxExtensionHandle); 1160 corePage()->userInputBridge().reloadFrame(m_mainFrame->coreFrame(), reloadFromOrigin );1158 corePage()->userInputBridge().reloadFrame(m_mainFrame->coreFrame(), reloadFromOrigin, contentBlockersEnabled); 1161 1159 } 1162 1160 … … 4918 4916 m_pendingNavigationID = 0; 4919 4917 } 4920 if (frame.page())4921 documentLoader->setUserContentExtensionsEnabled(frame.page()->userContentExtensionsEnabled());4922 4918 } 4923 4919 … … 5020 5016 } 5021 5017 5022 void WebPage::setUserContentExtensionsEnabled(bool userContentExtensionsEnabled)5023 {5024 if (!m_page)5025 return;5026 5027 m_page->setUserContentExtensionsEnabled(userContentExtensionsEnabled);5028 }5029 5030 5018 #if ENABLE(VIDEO) 5031 5019 void WebPage::mediaDocumentNaturalSizeChanged(const IntSize& newSize) -
branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h
r191171 r191459 964 964 void loadWebArchiveData(const IPC::DataReference&, const UserData&); 965 965 void navigateToPDFLinkWithSimulatedClick(const String& url, WebCore::IntPoint documentPoint, WebCore::IntPoint screenPoint); 966 void reload(uint64_t navigationID, bool reloadFromOrigin, const SandboxExtension::Handle&);966 void reload(uint64_t navigationID, bool reloadFromOrigin, bool contentBlockersEnabled, const SandboxExtension::Handle&); 967 967 void goForward(uint64_t navigationID, uint64_t); 968 968 void goBack(uint64_t navigationID, uint64_t); … … 1146 1146 1147 1147 void setShouldScaleViewToFitDocument(bool); 1148 void setUserContentExtensionsEnabled(bool);1149 1148 1150 1149 void pageStoppedScrolling(); -
branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
r191171 r191459 137 137 NavigateToPDFLinkWithSimulatedClick(String url, WebCore::IntPoint documentPoint, WebCore::IntPoint screenPoint) 138 138 139 Reload(uint64_t navigationID, bool reloadFromOrigin, WebKit::SandboxExtension::Handle sandboxExtensionHandle)139 Reload(uint64_t navigationID, bool reloadFromOrigin, bool contentBlockersEnabled, WebKit::SandboxExtension::Handle sandboxExtensionHandle) 140 140 StopLoading() 141 141 … … 435 435 ClearWheelEventTestTrigger() 436 436 SetShouldScaleViewToFitDocument(bool shouldScaleViewToFitDocument) 437 SetUserContentExtensionsEnabled(bool userContentExtensionsEnabled)438 437 } -
branches/safari-601.1.46-branch/Tools/ChangeLog
r191458 r191459 1 2015-10-20 Matthew Hanson <matthew_hanson@apple.com> 2 3 Merge r191063. rdar://problem/22900764 4 5 2015-10-14 Alex Christensen <achristensen@webkit.org> 6 7 Add SPI for reloading without content blockers 8 https://bugs.webkit.org/show_bug.cgi?id=150058 9 rdar://problem/22742222 10 11 Reviewed by Sam Weinig. 12 13 * WebKitTestRunner/cocoa/TestControllerCocoa.mm: 14 (WTR::TestController::cocoaResetStateToConsistentValues): 15 * WebKitTestRunner/mac/TestControllerMac.mm: 16 (WTR::TestController::platformConfigureViewForTest): 17 1 18 2015-10-20 Matthew Hanson <matthew_hanson@apple.com> 2 19 -
branches/safari-601.1.46-branch/Tools/WebKitTestRunner/mac/TestControllerMac.mm
r191458 r191459 137 137 }]; 138 138 platformRunUntil(doneCompiling, 0); 139 140 // This is for http/tests/contentextensions/disable-blocker.html141 if (!test.urlContains("disable-blocker"))142 return;143 mainWebView()->platformView()._userContentExtensionsEnabled = false;144 139 #endif 145 140 }
Note: See TracChangeset
for help on using the changeset viewer.