Changeset 192455 in webkit

Timestamp:

Nov 13, 2015 9:51:27 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Eliminate a request for layout every time an item is added to the stage of the graphics benchmark
​https://bugs.webkit.org/show_bug.cgi?id=151289

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-11-13
Reviewed by Simon Fraser.

Cache the stage size when it is created instead of requesting every time
an object is added via clientWidth and clientHeight.

• Animometer/resources/extensions.js:

(Insets.elementPadding):

• Animometer/tests/resources/stage.js:

(Stage):
(Stage.prototype.get size):

Location:

trunk/PerformanceTests

Files:

• Animometer/resources/extensions.js (modified) (1 diff)
• Animometer/tests/resources/stage.js (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/PerformanceTests/Animometer/resources/extensions.js

@@ -67 +67 @@
     this.bottom = bottom;
     this.left = left;
+}
+
+Insets.elementPadding = function(element)
+{
+    var styles = window.getComputedStyle(element);
+    return new Insets(
+        parseFloat(styles.paddingTop),
+        parseFloat(styles.paddingRight),
+        parseFloat(styles.paddingBottom),
+        parseFloat(styles.paddingTop));
 }
 

trunk/PerformanceTests/Animometer/tests/resources/stage.js

@@ -36 +36 @@
 {
     this.element = element;
+    this._size = Point.elementClientSize(element).subtract(Insets.elementPadding(element).size);
 }
 
@@ -42 +43 @@
     get size()
     {
-        var styles = window.getComputedStyle(this.element);
-        var padding = new Insets(
-            parseFloat(styles.paddingTop),
-            parseFloat(styles.paddingRight),
-            parseFloat(styles.paddingBottom),
-            parseFloat(styles.paddingTop));
-        return new Point(this.element.clientWidth - padding.width, this.element.clientHeight - padding.height);
+        return this._size
     },
     

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2015-11-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Eliminate a request for layout every time an item is added to the stage of the graphics benchmark
+        https://bugs.webkit.org/show_bug.cgi?id=151289
+
+        Reviewed by Simon Fraser.
+        
+        Cache the stage size when it is created instead of requesting every time
+        an object is added via clientWidth and clientHeight.
+
+        * Animometer/resources/extensions.js:
+        (Insets.elementPadding):
+        * Animometer/tests/resources/stage.js:
+        (Stage):
+        (Stage.prototype.get size):
+
 2015-11-06  Said Abou-Hallawa  <sabouhallawa@apple.com>