Changeset 192570 in webkit


Ignore:
Timestamp:
Nov 18, 2015 3:12:42 AM (9 years ago)
Author:
commit-queue@webkit.org
Message:

AX: Shadow DOM video player controls menus need aria-owns on the trigger buttons
​https://bugs.webkit.org/show_bug.cgi?id=127065

Patch by Aaron Chu <​arona.chu@gmail.com> on 2015-11-18
Reviewed by Darin Adler.

Source/WebCore:

Test: media/accessibility-closed-captions-has-aria-owns.html

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls):
(Controller.prototype.buildCaptionMenu):

  • Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.createControls):
(Controller.prototype.buildCaptionMenu):

LayoutTests:

  • media/accessibility-closed-captions-has-aria-owns-expected.txt: Added.
  • media/accessibility-closed-captions-has-aria-owns.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r192567 r192570  
     12015-11-18  Aaron Chu  <arona.chu@gmail.com>
     2
     3        AX: Shadow DOM video player controls menus need aria-owns on the trigger buttons
     4        https://bugs.webkit.org/show_bug.cgi?id=127065
     5
     6        Reviewed by Darin Adler.
     7
     8        * media/accessibility-closed-captions-has-aria-owns-expected.txt: Added.
     9        * media/accessibility-closed-captions-has-aria-owns.html: Added.
     10
    1112015-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r192567 r192570  
     12015-11-18  Aaron Chu  <arona.chu@gmail.com>
     2
     3        AX: Shadow DOM video player controls menus need aria-owns on the trigger buttons
     4        https://bugs.webkit.org/show_bug.cgi?id=127065
     5
     6        Reviewed by Darin Adler.
     7
     8        Test: media/accessibility-closed-captions-has-aria-owns.html
     9
     10        * Modules/mediacontrols/mediaControlsApple.js:
     11        (Controller.prototype.createControls):
     12        (Controller.prototype.buildCaptionMenu):
     13        * Modules/mediacontrols/mediaControlsBase.js:
     14        (Controller.prototype.createControls):
     15        (Controller.prototype.buildCaptionMenu):
     16
    1172015-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
    218

  • trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js

    r189401 r192570  
    469469        captionButton.setAttribute('aria-label', this.UIString('Captions'));
    470470        captionButton.setAttribute('aria-haspopup', 'true');
     471        captionButton.setAttribute('aria-owns', 'audioTrackMenu');
    471472        this.listenFor(captionButton, 'click', this.handleCaptionButtonClicked);
    472473
    … …  
    16471648        this.captionMenu = document.createElement('div');
    16481649        this.captionMenu.setAttribute('pseudo', '-webkit-media-controls-closed-captions-container');
     1650        this.captionMenu.setAttribute('id', 'audioTrackMenu');
    16491651        this.base.appendChild(this.captionMenu);
    16501652        this.captionMenuItems = [];

  • trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js

    r190054 r192570  
    397397        captionButton.setAttribute('aria-label', this.UIString('Captions'));
    398398        captionButton.setAttribute('aria-haspopup', 'true');
     399        captionButton.setAttribute('aria-owns', 'audioTrackMenu');
    399400        this.listenFor(captionButton, 'click', this.handleCaptionButtonClicked);
    400401
    … …  
    11341135        this.captionMenu = document.createElement('div');
    11351136        this.captionMenu.setAttribute('pseudo', '-webkit-media-controls-closed-captions-container');
     1137        this.captionMenu.setAttribute('id', 'audioTrackMenu');
    11361138        this.base.appendChild(this.captionMenu);
    11371139        this.captionMenuItems = [];
Note: See TracChangeset for help on using the changeset viewer.