Changeset 192818 in webkit

Timestamp:

Nov 30, 2015 1:12:43 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

Perf dashboard should extend baseline and target to the future
​https://bugs.webkit.org/show_bug.cgi?id=151511

Reviewed by Darin Adler.

• public/v2/data.js:

(RunsData.prototype.timeSeriesByCommitTime): Added extendToFuture as an argument.
(RunsData.prototype.timeSeriesByBuildTime): Ditto.
(RunsData.prototype._timeSeriesByTimeInternal): Ditto.
(TimeSeries): Add a new point to the end if extendToFuture is set and the series is not empty.

• public/v2/manifest.js:

(App.Manifest._formatFetchedData): Set extendToFuture to true for baselines and targets.

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/v2/data.js (modified) (4 diffs)
• public/v2/manifest.js (modified) (1 diff)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2015-11-30  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Perf dashboard should extend baseline and target to the future
+        https://bugs.webkit.org/show_bug.cgi?id=151511
+
+        Reviewed by Darin Adler.
+
+        * public/v2/data.js:
+        (RunsData.prototype.timeSeriesByCommitTime): Added extendToFuture as an argument.
+        (RunsData.prototype.timeSeriesByBuildTime): Ditto.
+        (RunsData.prototype._timeSeriesByTimeInternal): Ditto.
+        (TimeSeries): Add a new point to the end if extendToFuture is set and the series is not empty.
+        * public/v2/manifest.js:
+        (App.Manifest._formatFetchedData): Set extendToFuture to true for baselines and targets.
+
 2015-11-30  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/v2/data.js

@@ -324 +324 @@
 }
 
-RunsData.prototype.timeSeriesByCommitTime = function (includeOutliers)
-{
-    return this._timeSeriesByTimeInternal(true, includeOutliers);
-}
-
-RunsData.prototype.timeSeriesByBuildTime = function (includeOutliers)
-{
-    return this._timeSeriesByTimeInternal(false, includeOutliers);
-}
-
-RunsData.prototype._timeSeriesByTimeInternal = function (useCommitType, includeOutliers)
+RunsData.prototype.timeSeriesByCommitTime = function (includeOutliers, extendToFuture)
+{
+    return this._timeSeriesByTimeInternal(true, includeOutliers, extendToFuture);
+}
+
+RunsData.prototype.timeSeriesByBuildTime = function (includeOutliers, extendToFuture)
+{
+    return this._timeSeriesByTimeInternal(false, includeOutliers, extendToFuture);
+}
+
+RunsData.prototype._timeSeriesByTimeInternal = function (useCommitType, includeOutliers, extendToFuture)
 {
     var series = new Array();
@@ -350 +350 @@
         });
     }
-    return new TimeSeries(series);
+    return new TimeSeries(series, extendToFuture);
 }
 
@@ -421 +421 @@
 }
 
-function TimeSeries(series)
+// FIXME: Extending the baseline/target to the future should be a server-side configuration.
+function TimeSeries(series, extendToFuture)
 {
     this._series = series.sort(function (a, b) {
@@ -427 +428 @@
         return diff ? diff : a.secondaryTime - b.secondaryTime;
     });
+
+    if (extendToFuture && this._series.length) {
+        var lastPoint = this._series[this._series.length - 1];
+        this._series.push({
+            measurement: lastPoint.measurement,
+            time: Date.now() + 24 * 3600 * 1000,
+            secondaryTime: Date.now() + 24 * 3600 * 1000,
+            value: lastPoint.value,
+            interval: lastPoint.interval,
+            markedOutlier: lastPoint.markedOutlier,
+        });
+    }
 
     var self = this;

trunk/Websites/perf.webkit.org/public/v2/manifest.js

@@ -366 +366 @@
 
         var currentTimeSeries = configurations.current.timeSeriesByCommitTime(false);
-        var baselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(false) : null;
-        var targetTimeSeries = configurations.target ? configurations.target.timeSeriesByCommitTime(false) : null;
+        var baselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(false, true) : null;
+        var targetTimeSeries = configurations.target ? configurations.target.timeSeriesByCommitTime(false, true) : null;
 
         var unfilteredCurrentTimeSeries = configurations.current.timeSeriesByCommitTime(true);
-        var unfilteredBaselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(true) : null;
-        var unfilteredTargetTimeSeries = configurations.target ? configurations.target.timeSeriesByCommitTime(true) : null;
+        var unfilteredBaselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCommitTime(true, true) : null;
+        var unfilteredTargetTimeSeries = configurations.target ? configurations.target.timeSeriesByCommitTime(true, true) : null;
 
         return {