Changeset 194066 in webkit

Timestamp:

Dec 14, 2015, 3:10:22 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Copy message from console with a stack trace does not include source code locations
​https://bugs.webkit.org/show_bug.cgi?id=152270

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-12-14
Reviewed by Timothy Hatcher.

• UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype.toClipboardString):
When the the StackTrace was upgraded to a real collection of CallFrame
object's the CallFrame's got real SourceCodeLocation properties.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ConsoleMessageView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-12-14  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Copy message from console with a stack trace does not include source code locations
+        https://bugs.webkit.org/show_bug.cgi?id=152270
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WebInspector.ConsoleMessageView.prototype.toClipboardString):
+        When the the StackTrace was upgraded to a real collection of CallFrame
+        object's the CallFrame's got real SourceCodeLocation properties.
+
 2015-12-13  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

@@ -197 +197 @@
             this._message.stackTrace.callFrames.forEach(function(frame) {
                 clipboardString += "\n\t" + (frame.functionName || WebInspector.UIString("(anonymous function)"));
-                if (frame.url)
-                    clipboardString += " (" + WebInspector.displayNameForURL(frame.url) + ", line " + frame.lineNumber + ")";
+                if (frame.sourceCodeLocation)
+                    clipboardString += " (" + frame.sourceCodeLocation.originalLocationString() + ")";
             });
         } else {