Changeset 194073 in webkit

Timestamp:

Dec 14, 2015, 4:34:37 PM (11 years ago)

Author:

benjamin@webkit.org

Message:

Rename FTL::Output's ceil64() to doubleCeil()

Rubber-stamped by Filip Pizlo.

ceil64() was a bad name, that's the name convention we use for integers.

• ftl/FTLB3Output.h:

(JSC::FTL::Output::doubleCeil):
(JSC::FTL::Output::ceil64): Deleted.

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileArithRound):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ftl/FTLB3Output.h (modified) (2 diffs)
• ftl/FTLLowerDFGToLLVM.cpp (modified) (1 diff)
• ftl/FTLOutput.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-12-14  Benjamin Poulain  <benjamin@webkit.org>
+
+        Rename FTL::Output's ceil64() to doubleCeil()
+
+        Rubber-stamped by Filip Pizlo.
+
+        ceil64() was a bad name, that's the name convention we use for integers.
+
+        * ftl/FTLB3Output.h:
+        (JSC::FTL::Output::doubleCeil):
+        (JSC::FTL::Output::ceil64): Deleted.
+        * ftl/FTLLowerDFGToLLVM.cpp:
+        (JSC::FTL::DFG::LowerDFGToLLVM::compileArithRound):
+
 2015-12-14  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/ftl/FTLB3Output.h

@@ -155 +155 @@
     LValue bitNot(LValue);
 
-    LValue ceil64(LValue operand) { return m_block->appendNew<B3::Value>(m_proc, B3::Ceil, origin(), operand); }
     LValue ctlz32(LValue operand) { return m_block->appendNew<B3::Value>(m_proc, B3::Clz, origin(), operand); }
     LValue addWithOverflow32(LValue left, LValue right) { CRASH(); }
@@ -164 +163 @@
     LValue mulWithOverflow64(LValue left, LValue right) { CRASH(); }
     LValue doubleAbs(LValue value) { return m_block->appendNew<B3::Value>(m_proc, B3::Abs, origin(), value); }
+    LValue doubleCeil(LValue operand) { return m_block->appendNew<B3::Value>(m_proc, B3::Ceil, origin(), operand); }
 
     LValue doubleSin(LValue value) { return callWithoutSideEffects(B3::Double, sin, value); }

trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp

@@ -2126 +2126 @@
 
         LValue value = lowDouble(m_node->child1());
-        LValue integerValue = m_out.ceil64(value);
+        LValue integerValue = m_out.doubleCeil(value);
         ValueFromBlock integerValueResult = m_out.anchor(integerValue);
 

trunk/Source/JavaScriptCore/ftl/FTLOutput.h

@@ -148 +148 @@
     LValue insertElement(LValue vector, LValue element, LValue index) { return buildInsertElement(m_builder, vector, element, index); }
 
-    LValue ceil64(LValue operand)
+    LValue ctlz32(LValue operand)
+    {
+        return call(int32, ctlz32Intrinsic(), operand, booleanFalse);
+    }
+    LValue addWithOverflow32(LValue left, LValue right)
+    {
+        return call(int32, addWithOverflow32Intrinsic(), left, right);
+    }
+    LValue subWithOverflow32(LValue left, LValue right)
+    {
+        return call(int32, subWithOverflow32Intrinsic(), left, right);
+    }
+    LValue mulWithOverflow32(LValue left, LValue right)
+    {
+        return call(int32, mulWithOverflow32Intrinsic(), left, right);
+    }
+    LValue addWithOverflow64(LValue left, LValue right)
+    {
+        return call(int64, addWithOverflow64Intrinsic(), left, right);
+    }
+    LValue subWithOverflow64(LValue left, LValue right)
+    {
+        return call(int64, subWithOverflow64Intrinsic(), left, right);
+    }
+    LValue mulWithOverflow64(LValue left, LValue right)
+    {
+        return call(int64, mulWithOverflow64Intrinsic(), left, right);
+    }
+    LValue doubleAbs(LValue value)
+    {
+        return call(doubleType, doubleAbsIntrinsic(), value);
+    }
+    LValue doubleCeil(LValue operand)
     {
         return call(doubleType, ceil64Intrinsic(), operand);
-    }
-    LValue ctlz32(LValue operand)
-    {
-        return call(int32, ctlz32Intrinsic(), operand, booleanFalse);
-    }
-    LValue addWithOverflow32(LValue left, LValue right)
-    {
-        return call(int32, addWithOverflow32Intrinsic(), left, right);
-    }
-    LValue subWithOverflow32(LValue left, LValue right)
-    {
-        return call(int32, subWithOverflow32Intrinsic(), left, right);
-    }
-    LValue mulWithOverflow32(LValue left, LValue right)
-    {
-        return call(int32, mulWithOverflow32Intrinsic(), left, right);
-    }
-    LValue addWithOverflow64(LValue left, LValue right)
-    {
-        return call(int64, addWithOverflow64Intrinsic(), left, right);
-    }
-    LValue subWithOverflow64(LValue left, LValue right)
-    {
-        return call(int64, subWithOverflow64Intrinsic(), left, right);
-    }
-    LValue mulWithOverflow64(LValue left, LValue right)
-    {
-        return call(int64, mulWithOverflow64Intrinsic(), left, right);
-    }
-    LValue doubleAbs(LValue value)
-    {
-        return call(doubleType, doubleAbsIntrinsic(), value);
     }