Changeset 19409 in webkit

Timestamp:

Feb 5, 2007 1:10:49 PM (17 years ago)

Author:

bdakin

Message:

Reviewed by Adam.

Fix for <rdar://problem/4975161> REGRESSION: With BumperCar 2.1.1,
the contextual menu fails to appear when I ctrl-click on page

• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): If the delegate does not respond to contextMenuItemsForElement, return the default menu instead of nil.

Location:

trunk/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/WebContextMenuClient.mm (modified) (1 diff)

trunk/WebKit/ChangeLog

@@ +1 @@
+2007-02-05  Beth Dakin  <bdakin@apple.com>
+
+        Reviewed by Adam.
+
+        Fix for <rdar://problem/4975161> REGRESSION: With BumperCar 2.1.1, 
+        the contextual menu fails to appear when I ctrl-click on page
+
+        * WebCoreSupport/WebContextMenuClient.mm:
+        (WebContextMenuClient::getCustomMenuFromDefaultItems): If the 
+        delegate does not respond to contextMenuItemsForElement, return the 
+        default menu instead of nil.
+
 2007-02-01  Geoffrey Garen  <ggaren@apple.com>
 

trunk/WebKit/WebCoreSupport/WebContextMenuClient.mm

@@ -169 +169 @@
     id delegate = [m_webView UIDelegate];
     if (![delegate respondsToSelector:@selector(webView:contextMenuItemsForElement:defaultMenuItems:)])
-        return nil;
+        return defaultMenu->platformDescription();
     
     NSDictionary *element = [[[WebElementDictionary alloc] initWithHitTestResult:defaultMenu->hitTestResult()] autorelease];