⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 194322 in webkit


Ignore:
Timestamp:
Dec 20, 2015, 1:57:01 PM (11 years ago)
Author:
mitz@apple.com
Message:

Remove unused setToolbarHeight
​https://bugs.webkit.org/show_bug.cgi?id=152466

Reviewed by Darin Adler.

Source/WebCore:

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setToolbarHeight): Deleted.

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • testing/Internals.cpp:

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

  • UserInterface/Protocol/InspectorFrontendHostStub.js:

(window.InspectorFrontendHost.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight): Deleted.

Source/WebKit/ios:

  • WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::setToolbarHeight): Deleted.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm::

(WebInspectorFrontendClient::setToolbarHeight): Deleted.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::setToolbarHeight): Deleted.

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::setToolbarHeight): Deleted.

  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.

  • WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::setToolbarHeight): Deleted.

  • WebProcess/WebPage/WebInspectorUI.h:
Location:
trunk/Source
Files:
26 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r194319 r194322  
     12015-12-20  Dan Bernstein  <mitz@apple.com>
     2
     3        Remove unused setToolbarHeight
     4        https://bugs.webkit.org/show_bug.cgi?id=152466
     5
     6        Reviewed by Darin Adler.
     7
     8        * inspector/InspectorFrontendClient.h:
     9        * inspector/InspectorFrontendHost.cpp:
     10        (WebCore::InspectorFrontendHost::setToolbarHeight): Deleted.
     11        * inspector/InspectorFrontendHost.h:
     12        * inspector/InspectorFrontendHost.idl:
     13        * testing/Internals.cpp:
     14
    1152015-12-20  Commit Queue  <commit-queue@webkit.org>
    216

  • trunk/Source/WebCore/inspector/InspectorFrontendClient.h

    r192756 r194322  
    6565    WEBCORE_EXPORT virtual void changeAttachedWindowWidth(unsigned) = 0;
    6666
    67     virtual void setToolbarHeight(unsigned) = 0;
    68 
    6967    WEBCORE_EXPORT virtual void openInNewTab(const String& url) = 0;
    7068

  • trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp

    r192756 r194322  
    209209}
    210210
    211 void InspectorFrontendHost::setToolbarHeight(unsigned height)
    212 {
    213     if (m_client)
    214         m_client->setToolbarHeight(height);
    215 }
    216 
    217211void InspectorFrontendHost::startWindowDrag()
    218212{

  • trunk/Source/WebCore/inspector/InspectorFrontendHost.h

    r192756 r194322  
    6565    void setAttachedWindowHeight(unsigned);
    6666    void setAttachedWindowWidth(unsigned);
    67     void setToolbarHeight(unsigned);
    6867
    6968    void startWindowDrag();

  • trunk/Source/WebCore/inspector/InspectorFrontendHost.idl

    r192756 r194322  
    4747    void setAttachedWindowHeight(unsigned long height);
    4848    void setAttachedWindowWidth(unsigned long width);
    49     void setToolbarHeight(unrestricted float height);
    5049
    5150    void startWindowDrag();

  • trunk/Source/WebCore/testing/Internals.cpp

    r194117 r194322  
    235235    virtual void setAttachedWindowHeight(unsigned) override { }
    236236    virtual void setAttachedWindowWidth(unsigned) override { }
    237     virtual void setToolbarHeight(unsigned) override { }
    238237
    239238public:

  • trunk/Source/WebInspectorUI/ChangeLog

    r194318 r194322  
     12015-12-20  Dan Bernstein  <mitz@apple.com>
     2
     3        Remove unused setToolbarHeight
     4        https://bugs.webkit.org/show_bug.cgi?id=152466
     5
     6        Reviewed by Darin Adler.
     7
     8        * UserInterface/Base/Main.js:
     9        (WebInspector.contentLoaded):
     10        * UserInterface/Protocol/InspectorFrontendHostStub.js:
     11        (window.InspectorFrontendHost.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight): Deleted.
     12
    1132015-12-19  Dan Bernstein  <mitz@apple.com>
    214

  • trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

    r194311 r194322  
    367367
    368368    this._updateDockNavigationItems();
    369     this._updateToolbarHeight();
    370369    this._setupViewHierarchy();
    371370
    … …  
    14371436};
    14381437
    1439 WebInspector._updateToolbarHeight = function()
    1440 {
    1441     if (WebInspector.Platform.name === "mac" && WebInspector.Platform.version.release < 10)
    1442         InspectorFrontendHost.setToolbarHeight(this.toolbar.element.offsetHeight);
    1443 };
    1444 
    14451438WebInspector._setupViewHierarchy = function()
    14461439{

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js

    r192756 r194322  
    8282
    8383        setAttachedWindowWidth: function(width)
    84         {
    85         },
    86 
    87         setToolbarHeight: function(width)
    8884        {
    8985        },

  • trunk/Source/WebKit/ios/ChangeLog

    r194307 r194322  
     12015-12-20  Dan Bernstein  <mitz@apple.com>
     2
     3        Remove unused setToolbarHeight
     4        https://bugs.webkit.org/show_bug.cgi?id=152466
     5
     6        Reviewed by Darin Adler.
     7
     8        * WebCoreSupport/WebInspectorClientIOS.mm:
     9        (WebInspectorFrontendClient::setToolbarHeight): Deleted.
     10
    1112015-12-18  Simon Fraser  <simon.fraser@apple.com>
    212

  • trunk/Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm

    r189970 r194322  
    129129void WebInspectorFrontendClient::setAttachedWindowHeight(unsigned) { }
    130130void WebInspectorFrontendClient::setAttachedWindowWidth(unsigned) { }
    131 void WebInspectorFrontendClient::setToolbarHeight(unsigned) { }
    132131void WebInspectorFrontendClient::startWindowDrag() { }
    133132void WebInspectorFrontendClient::inspectedURLChanged(const String&) { }

  • trunk/Source/WebKit/mac/ChangeLog

    r194318 r194322  
     12015-12-20  Dan Bernstein  <mitz@apple.com>
     2
     3        Remove unused setToolbarHeight
     4        https://bugs.webkit.org/show_bug.cgi?id=152466
     5
     6        Reviewed by Darin Adler.
     7
     8        * WebCoreSupport/WebInspectorClient.h:
     9        * WebCoreSupport/WebInspectorClient.mm::
     10        (WebInspectorFrontendClient::setToolbarHeight): Deleted.
     11
    1122015-12-19  Dan Bernstein  <mitz@apple.com>
    213

  • trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h

    r189970 r194322  
    120120    virtual void setAttachedWindowHeight(unsigned height) override;
    121121    virtual void setAttachedWindowWidth(unsigned height) override;
    122     virtual void setToolbarHeight(unsigned) override;
    123122
    124123    virtual void inspectedURLChanged(const String& newURL) override;

  • trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm

    r194318 r194322  
    273273}
    274274
    275 void WebInspectorFrontendClient::setToolbarHeight(unsigned height)
    276 {
    277 }
    278 
    279275void WebInspectorFrontendClient::inspectedURLChanged(const String& newURL)
    280276{

  • trunk/Source/WebKit/win/ChangeLog

    r194103 r194322  
     12015-12-20  Dan Bernstein  <mitz@apple.com>
     2
     3        Remove unused setToolbarHeight
     4        https://bugs.webkit.org/show_bug.cgi?id=152466
     5
     6        Reviewed by Darin Adler.
     7
     8        * WebCoreSupport/WebInspectorClient.cpp:
     9        (WebInspectorFrontendClient::setToolbarHeight): Deleted.
     10        * WebCoreSupport/WebInspectorClient.h:
     11
    1122015-12-15  Zan Dobersek  <zdobersek@igalia.com>
    213

  • trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp

    r189970 r194322  
    328328}
    329329
    330 void WebInspectorFrontendClient::setToolbarHeight(unsigned)
    331 {
    332     notImplemented();
    333 }
    334 
    335330void WebInspectorFrontendClient::inspectedURLChanged(const String& newURL)
    336331{

  • trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h

    r189970 r194322  
    106106    virtual void setAttachedWindowHeight(unsigned) override;
    107107    virtual void setAttachedWindowWidth(unsigned) override;
    108     virtual void setToolbarHeight(unsigned) override;
    109108
    110109    virtual void inspectedURLChanged(const WTF::String& newURL) override;

  • trunk/Source/WebKit2/ChangeLog

    r194318 r194322  
     12015-12-20  Dan Bernstein  <mitz@apple.com>
     2
     3        Remove unused setToolbarHeight
     4        https://bugs.webkit.org/show_bug.cgi?id=152466
     5
     6        Reviewed by Darin Adler.
     7
     8        * UIProcess/WebInspectorProxy.cpp:
     9        (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
     10        * UIProcess/WebInspectorProxy.h:
     11        (WebKit::WebInspectorProxy::setToolbarHeight): Deleted.
     12        * UIProcess/WebInspectorProxy.messages.in:
     13        * UIProcess/efl/WebInspectorProxyEfl.cpp:
     14        (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
     15        * UIProcess/gtk/WebInspectorProxyGtk.cpp:
     16        (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
     17        * UIProcess/mac/WebInspectorProxyMac.mm:
     18        (WebKit::WebInspectorProxy::platformSetToolbarHeight): Deleted.
     19        * WebProcess/WebPage/WebInspectorUI.cpp:
     20        (WebKit::WebInspectorUI::setToolbarHeight): Deleted.
     21        * WebProcess/WebPage/WebInspectorUI.h:
     22
    1232015-12-19  Dan Bernstein  <mitz@apple.com>
    224

  • trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp

    r193877 r194322  
    733733}
    734734
    735 void WebInspectorProxy::platformSetToolbarHeight(unsigned)
    736 {
    737     notImplemented();
    738 }
    739 
    740735void WebInspectorProxy::platformStartWindowDrag()
    741736{

  • trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h

    r192756 r194322  
    129129    void setAttachedWindowHeight(unsigned);
    130130    void setAttachedWindowWidth(unsigned);
    131     void setToolbarHeight(unsigned height) { platformSetToolbarHeight(height); }
    132131
    133132    void startWindowDrag();
    … …  
    177176    void platformSetAttachedWindowHeight(unsigned);
    178177    void platformSetAttachedWindowWidth(unsigned);
    179     void platformSetToolbarHeight(unsigned);
    180178    void platformStartWindowDrag();
    181179    void platformSave(const String& filename, const String& content, bool base64Encoded, bool forceSaveAs);

  • trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in

    r185968 r194322  
    4040    SetAttachedWindowHeight(unsigned height)
    4141    SetAttachedWindowWidth(unsigned width)
    42     SetToolbarHeight(unsigned height)
    4342
    4443    StartWindowDrag()

  • trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp

    r192196 r194322  
    233233}
    234234
    235 void WebInspectorProxy::platformSetToolbarHeight(unsigned)
    236 {
    237     notImplemented();
    238 }
    239 
    240235void WebInspectorProxy::platformStartWindowDrag()
    241236{

  • trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp

    r192761 r194322  
    344344}
    345345
    346 void WebInspectorProxy::platformSetToolbarHeight(unsigned)
     346void WebInspectorProxy::platformStartWindowDrag()
    347347{
    348348    notImplemented();
    349349}
    350350
    351 void WebInspectorProxy::platformStartWindowDrag()
     351void WebInspectorProxy::platformSave(const String&, const String&, bool, bool)
    352352{
    353353    notImplemented();
    354354}
    355355
    356 void WebInspectorProxy::platformSave(const String&, const String&, bool, bool)
     356void WebInspectorProxy::platformAppend(const String&, const String&)
    357357{
    358358    notImplemented();
    359359}
    360360
    361 void WebInspectorProxy::platformAppend(const String&, const String&)
    362 {
    363     notImplemented();
    364 }
    365 
    366361void WebInspectorProxy::platformAttachAvailabilityChanged(bool available)
    367362{

  • trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm

    r194318 r194322  
    785785}
    786786
    787 void WebInspectorProxy::platformSetToolbarHeight(unsigned height)
    788 {
    789 }
    790 
    791787void WebInspectorProxy::platformStartWindowDrag()
    792788{

  • trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp

    r192809 r194322  
    188188}
    189189
    190 void WebInspectorUI::setToolbarHeight(unsigned height)
    191 {
    192     WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::SetToolbarHeight(height), m_inspectedPageIdentifier);
    193 }
    194 
    195190void WebInspectorUI::openInNewTab(const String& url)
    196191{

  • trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h

    r192809 r194322  
    9292    void changeAttachedWindowWidth(unsigned) override;
    9393
    94     void setToolbarHeight(unsigned) override;
    95 
    9694    void openInNewTab(const String& url) override;
    9795
Note: See TracChangeset for help on using the changeset viewer.