Changeset 194360 in webkit

Timestamp:

Dec 21, 2015, 10:07:23 PM (11 years ago)

Author:

Nikita Vasilyev

Message:

WebInspector: Can't open a new tab: Uncaught Exception: TypeError: this.isNewTabWithTypeAllowed is not a function
​https://bugs.webkit.org/show_bug.cgi?id=152471

Reviewed by Timothy Hatcher.

• UserInterface/Base/Main.js:

(WebInspector._updateNewTabButtonState):
Don't use arrow functions because of ​https://webkit.org/b/152497 "Arrow functions: 'this' isn't lexically bound"

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-12-21  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        WebInspector: Can't open a new tab: Uncaught Exception: TypeError: this.isNewTabWithTypeAllowed is not a function
+        https://bugs.webkit.org/show_bug.cgi?id=152471
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Base/Main.js:
+        (WebInspector._updateNewTabButtonState):
+        Don't use arrow functions because of https://webkit.org/b/152497 "Arrow functions: 'this' isn't lexically bound"
+
 2015-12-21  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -491 +491 @@
     let allTabs = [...this._knownTabClassesByType.values()];
     let addableTabs = allTabs.filter((tabClass) => !tabClass.isEphemeral());
-    let canMakeNewTab = addableTabs.some((tabClass) => this.isNewTabWithTypeAllowed(tabClass.Type));
+
+    // FIXME: Use arrow functions once http://webkit.org/b/152497 is resolved.
+    let canMakeNewTab = addableTabs.some(function(tabClass) {
+        return this.isNewTabWithTypeAllowed(tabClass.Type);
+    }.bind(this));
     this.tabBar.newTabItem.disabled = !canMakeNewTab;
 };