Changeset 194373 in webkit

Timestamp:

Dec 22, 2015, 2:19:31 PM (11 years ago)

Author:

sbarati@apple.com

Message:

Work around issue in bug #152510
​https://bugs.webkit.org/show_bug.cgi?id=152511

Reviewed by Filip Pizlo.

• runtime/Options.cpp:

(JSC::recomputeDependentOptions):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Options.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-12-22  Saam barati  <sbarati@apple.com>
+
+        Work around issue in bug #152510
+        https://bugs.webkit.org/show_bug.cgi?id=152511
+
+        Reviewed by Filip Pizlo.
+
+        * runtime/Options.cpp:
+        (JSC::recomputeDependentOptions):
+
 2015-12-22  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Options.cpp

@@ -27 +27 @@
 #include "Options.h"
 
+#include "CCallHelpers.h"
 #include <algorithm>
 #include <limits>
@@ -315 +316 @@
         Options::useOSREntryToDFG() = false;
         Options::useOSREntryToFTL() = false;
+    }
+
+    if (isARM64()) {
+        // FIXME: https://bugs.webkit.org/show_bug.cgi?id=152510
+        // We're running into a bug where some ARM64 tests are failing in the FTL
+        // with what appears to be an llvm bug where llvm is miscalculating the
+        // live-out variables of a patchpoint. This causes us to not keep a 
+        // volatile register alive across a C call in a patchpoint, even though 
+        // that register is used immediately after the patchpoint.
+        Options::assumeAllRegsInFTLICAreLive() = true;
     }