Changeset 194406 in webkit

Timestamp:

Dec 23, 2015, 5:10:55 PM (11 years ago)

Author:

Dewei Zhu

Message:

SVN checkout used by RunBenchmark should be non-interactive
​https://bugs.webkit.org/show_bug.cgi?id=152542

Reviewed by Ryosuke Niwa.

RunBenchmark should not require user interaction while running.

• Scripts/webkitpy/benchmark_runner/benchmark_builder.py:

(BenchmarkBuilder._checkout_with_subversion):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/benchmark_runner/benchmark_builder.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
+
+        SVN checkout used by RunBenchmark should be non-interactive
+        https://bugs.webkit.org/show_bug.cgi?id=152542
+
+        Reviewed by Ryosuke Niwa.
+
+        RunBenchmark should not require user interaction while running.
+
+        * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
+        (BenchmarkBuilder._checkout_with_subversion):
+
 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py

@@ -87 +87 @@
     def _checkout_with_subversion(self, subversion_url):
         _log.info('Checking out %s to %s' % (subversion_url, self._dest))
-        error_code = subprocess.call(['svn', 'checkout', subversion_url, self._dest])
+        error_code = subprocess.call(['svn', 'checkout', '--trust-server-cert', '--non-interactive', subversion_url, self._dest])
         if error_code:
             raise Exception('Cannot checkout the benchmark - Error: %s' % error_code)