⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 194413 in webkit


Ignore:
Timestamp:
Dec 23, 2015, 11:39:01 PM (11 years ago)
Author:
beidson@apple.com
Message:

Modern IDB: storage/indexeddb/transaction-basics.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=152481

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Failing test now passes).

  • Modules/indexeddb/client/IDBDatabaseImpl.cpp:

(WebCore::IDBClient::IDBDatabase::transaction): Include the invalid string argument

in the error message.

LayoutTests:

  • platform/mac-wk1/TestExpectations:
  • storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r194412 r194413  
     12015-12-23  Brady Eidson  <beidson@apple.com>
     2
     3        Modern IDB: storage/indexeddb/transaction-basics.html fails.
     4        https://bugs.webkit.org/show_bug.cgi?id=152481
     5
     6        Reviewed by Alex Christensen.
     7
     8        * platform/mac-wk1/TestExpectations:
     9        * storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
     10        * storage/indexeddb/transaction-basics-expected.txt:
     11
    1122015-12-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
    213

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r194365 r194413  
    108108storage/indexeddb/properties-disabled-at-runtime.html [ Failure ]
    109109storage/indexeddb/setversion-blocked-by-versionchange-close.html [ Failure ]
    110 storage/indexeddb/transaction-basics.html [ Failure ]
    111110storage/indexeddb/transaction-scope-sequencing.html [ Failure ]
    112111

  • trunk/LayoutTests/storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt

    r193494 r194413  
    44ALERT: Failed to start a transaction with an empty set of object stores - Error: Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.
    55ALERT: Failed to start a transaction to a nonexistent object store - Error: Failed to execute 'transaction' on 'IDBDatabase': One of the specified object stores was not found.
    6 ALERT: Failed to start a transaction with an invalid mode - TypeError: Failed to execute 'transaction' on 'IDBDatabase': The mode provided ('invalid-mode') is not one of 'readonly' or 'readwrite'.
    7 ALERT: Failed to explicitly start a versionchange transaction - TypeError: Failed to execute 'transaction' on 'IDBDatabase': The mode provided ('invalid-mode') is not one of 'readonly' or 'readwrite'.
     6ALERT: Failed to start a transaction with an invalid mode - TypeError: Failed to execute 'transaction' on 'IDBDatabase': The mode provided ('blahblah') is not one of 'readonly' or 'readwrite'.
     7ALERT: Failed to explicitly start a versionchange transaction - TypeError: Failed to execute 'transaction' on 'IDBDatabase': The mode provided ('versionchange') is not one of 'readonly' or 'readwrite'.
    88ALERT: Failed to explicitly start a transaction with the close pending flag set - Error: Failed to execute 'transaction' on 'IDBDatabase': The database connection is closing.
    99ALERT: Done

  • trunk/LayoutTests/storage/indexeddb/transaction-basics-expected.txt

    r163963 r194413  
    2424PASS code is DOMException.INVALID_STATE_ERR
    2525PASS ename is 'InvalidStateError'
    26 Exception message: Failed to execute 'deleteIndex' on 'IDBObjectStore': The object store has been deleted.
     26Exception message: An operation was called on an object on which it is not allowed or at a time when it is not allowed.
    2727
    2828testSetVersionAbort2():
    … …  
    4242PASS code is DOMException.INVALID_STATE_ERR
    4343PASS ename is 'InvalidStateError'
    44 Exception message: Failed to execute 'deleteIndex' on 'IDBObjectStore': The object store has been deleted.
     44Exception message: An operation was called on an object on which it is not allowed or at a time when it is not allowed.
    4545store = db.createObjectStore('storeFail', null)
    4646index = store.createIndex('indexFail', 'x')
    … …  
    6565PASS code is 0
    6666PASS ename is 'TransactionInactiveError'
    67 Exception message: Failed to execute 'openCursor' on 'IDBIndex': The transaction has finished.
     67Exception message: Failed to execute 'openCursor' on 'IDBIndex': The transaction is inactive or finished.
    6868Expecting exception from index.openKeyCursor()
    6969PASS Exception was thrown.
    7070PASS code is 0
    7171PASS ename is 'TransactionInactiveError'
    72 Exception message: Failed to execute 'openKeyCursor' on 'IDBIndex': The transaction has finished.
     72Exception message: Failed to execute 'openKeyCursor' on 'IDBIndex': The transaction is inactive or finished.
    7373Expecting exception from index.get(0)
    7474PASS Exception was thrown.
    7575PASS code is 0
    7676PASS ename is 'TransactionInactiveError'
    77 Exception message: Failed to execute 'get' on 'IDBIndex': The transaction has finished.
     77Exception message: Failed to execute 'get' on 'IDBIndex': The transaction is inactive or finished.
    7878Expecting exception from index.getKey(0)
    7979PASS Exception was thrown.
    8080PASS code is 0
    8181PASS ename is 'TransactionInactiveError'
    82 Exception message: Failed to execute 'getKey' on 'IDBIndex': The transaction has finished.
     82Exception message: Failed to execute 'getKey' on 'IDBIndex': The transaction is inactive or finished.
    8383Expecting exception from index.count()
    8484PASS Exception was thrown.
    8585PASS code is 0
    8686PASS ename is 'TransactionInactiveError'
    87 Exception message: Failed to execute 'count' on 'IDBIndex': The transaction has finished.
     87Exception message: Failed to execute 'count' on 'IDBIndex': The transaction is inactive or finished.
    8888Expecting exception from store.put(0, 0)
    8989PASS Exception was thrown.
    9090PASS code is 0
    9191PASS ename is 'TransactionInactiveError'
    92 Exception message: Failed to execute 'put' on 'IDBObjectStore': The transaction has finished.
     92Exception message: Failed to store record in an IDBObjectStore: The transaction is inactive or finished.
    9393Expecting exception from store.add(0, 0)
    9494PASS Exception was thrown.
    9595PASS code is 0
    9696PASS ename is 'TransactionInactiveError'
    97 Exception message: Failed to execute 'add' on 'IDBObjectStore': The transaction has finished.
     97Exception message: Failed to store record in an IDBObjectStore: The transaction is inactive or finished.
    9898Expecting exception from store.delete(0)
    9999PASS Exception was thrown.
    100100PASS code is 0
    101101PASS ename is 'TransactionInactiveError'
    102 Exception message: Failed to execute 'delete' on 'IDBObjectStore': The transaction has finished.
     102Exception message: Failed to execute 'delete' on 'IDBObjectStore': The transaction is inactive or finished.
    103103Expecting exception from store.clear()
    104104PASS Exception was thrown.
    105105PASS code is 0
    106106PASS ename is 'TransactionInactiveError'
    107 Exception message: Failed to execute 'clear' on 'IDBObjectStore': The transaction has finished.
     107Exception message: Failed to execute 'clear' on 'IDBObjectStore': The transaction is inactive or finished.
    108108Expecting exception from store.get(0)
    109109PASS Exception was thrown.
    110110PASS code is 0
    111111PASS ename is 'TransactionInactiveError'
    112 Exception message: Failed to execute 'get' on 'IDBObjectStore': The transaction has finished.
     112Exception message: Failed to execute 'get' on 'IDBObjectStore': The transaction is inactive or finished.
    113113Expecting exception from store.openCursor()
    114114PASS Exception was thrown.
    115115PASS code is 0
    116116PASS ename is 'TransactionInactiveError'
    117 Exception message: Failed to execute 'openCursor' on 'IDBObjectStore': The transaction has finished.
     117Exception message: Failed to execute 'openCursor' on 'IDBObjectStore': The transaction is inactive or finished.
    118118
    119119testSetVersionAbort4():
    … …  
    134134PASS code is 0
    135135PASS ename is 'TransactionInactiveError'
    136 Exception message: Failed to execute 'openCursor' on 'IDBIndex': The transaction has finished.
     136Exception message: Failed to execute 'openCursor' on 'IDBIndex': The transaction is inactive or finished.
    137137Expecting exception from index.openKeyCursor()
    138138PASS Exception was thrown.
    139139PASS code is 0
    140140PASS ename is 'TransactionInactiveError'
    141 Exception message: Failed to execute 'openKeyCursor' on 'IDBIndex': The transaction has finished.
     141Exception message: Failed to execute 'openKeyCursor' on 'IDBIndex': The transaction is inactive or finished.
    142142Expecting exception from index.get(0)
    143143PASS Exception was thrown.
    144144PASS code is 0
    145145PASS ename is 'TransactionInactiveError'
    146 Exception message: Failed to execute 'get' on 'IDBIndex': The transaction has finished.
     146Exception message: Failed to execute 'get' on 'IDBIndex': The transaction is inactive or finished.
    147147Expecting exception from index.getKey(0)
    148148PASS Exception was thrown.
    149149PASS code is 0
    150150PASS ename is 'TransactionInactiveError'
    151 Exception message: Failed to execute 'getKey' on 'IDBIndex': The transaction has finished.
     151Exception message: Failed to execute 'getKey' on 'IDBIndex': The transaction is inactive or finished.
    152152Expecting exception from index.count()
    153153PASS Exception was thrown.
    154154PASS code is 0
    155155PASS ename is 'TransactionInactiveError'
    156 Exception message: Failed to execute 'count' on 'IDBIndex': The transaction has finished.
     156Exception message: Failed to execute 'count' on 'IDBIndex': The transaction is inactive or finished.
    157157Expecting exception from store.put(0, 0)
    158158PASS Exception was thrown.
    159159PASS code is 0
    160160PASS ename is 'TransactionInactiveError'
    161 Exception message: Failed to execute 'put' on 'IDBObjectStore': The transaction has finished.
     161Exception message: Failed to store record in an IDBObjectStore: The transaction is inactive or finished.
    162162Expecting exception from store.add(0, 0)
    163163PASS Exception was thrown.
    164164PASS code is 0
    165165PASS ename is 'TransactionInactiveError'
    166 Exception message: Failed to execute 'add' on 'IDBObjectStore': The transaction has finished.
     166Exception message: Failed to store record in an IDBObjectStore: The transaction is inactive or finished.
    167167Expecting exception from store.delete(0)
    168168PASS Exception was thrown.
    169169PASS code is 0
    170170PASS ename is 'TransactionInactiveError'
    171 Exception message: Failed to execute 'delete' on 'IDBObjectStore': The transaction has finished.
     171Exception message: Failed to execute 'delete' on 'IDBObjectStore': The transaction is inactive or finished.
    172172Expecting exception from store.clear()
    173173PASS Exception was thrown.
    174174PASS code is 0
    175175PASS ename is 'TransactionInactiveError'
    176 Exception message: Failed to execute 'clear' on 'IDBObjectStore': The transaction has finished.
     176Exception message: Failed to execute 'clear' on 'IDBObjectStore': The transaction is inactive or finished.
    177177Expecting exception from store.get(0)
    178178PASS Exception was thrown.
    179179PASS code is 0
    180180PASS ename is 'TransactionInactiveError'
    181 Exception message: Failed to execute 'get' on 'IDBObjectStore': The transaction has finished.
     181Exception message: Failed to execute 'get' on 'IDBObjectStore': The transaction is inactive or finished.
    182182Expecting exception from store.openCursor()
    183183PASS Exception was thrown.
    184184PASS code is 0
    185185PASS ename is 'TransactionInactiveError'
    186 Exception message: Failed to execute 'openCursor' on 'IDBObjectStore': The transaction has finished.
     186Exception message: Failed to execute 'openCursor' on 'IDBObjectStore': The transaction is inactive or finished.
    187187
    188188testSetVersionAbort5():

  • trunk/Source/WebCore/ChangeLog

    r194410 r194413  
     12015-12-23  Brady Eidson  <beidson@apple.com>
     2
     3        Modern IDB: storage/indexeddb/transaction-basics.html fails.
     4        https://bugs.webkit.org/show_bug.cgi?id=152481
     5
     6        Reviewed by Alex Christensen.
     7
     8        No new tests (Failing test now passes).
     9
     10        * Modules/indexeddb/client/IDBDatabaseImpl.cpp:
     11        (WebCore::IDBClient::IDBDatabase::transaction): Include the invalid string argument
     12          in the error message.
     13
    1142015-12-23  Simon Fraser  <simon.fraser@apple.com>
    215

  • trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp

    r193871 r194413  
    157157    IndexedDB::TransactionMode mode = IDBTransaction::stringToMode(modeString, ec.code);
    158158    if (ec.code) {
    159         ec.message = ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The mode provided ('invalid-mode') is not one of 'readonly' or 'readwrite'.");
     159        ec.message = makeString(ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The mode provided ('"), modeString, ASCIILiteral("') is not one of 'readonly' or 'readwrite'."));
    160160        return nullptr;
    161161    }
Note: See TracChangeset for help on using the changeset viewer.