Changeset 194415 in webkit

Timestamp:

Dec 24, 2015, 2:42:53 AM (11 years ago)

Author:

youenn.fablet@crf.canon.fr

Message:

Python SCM should be able to retrieve untracked files - Generic changes
​https://bugs.webkit.org/show_bug.cgi?id=152536

Reviewed by Brent Fulgham.

This patch introduces SCM.untracked_files to retrieve a list of untracked files.
No support is yet added to GIT and SVN specific implementations.

• Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.untracked_files):

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._shared_test_untracked_files):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/checkout/scm/scm.py (modified) (1 diff)
• Scripts/webkitpy/common/checkout/scm/scm_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        Python SCM should be able to retrieve untracked files - Generic changes
+        https://bugs.webkit.org/show_bug.cgi?id=152536
+
+        Reviewed by Brent Fulgham.
+
+        This patch introduces SCM.untracked_files to retrieve a list of untracked files.
+        No support is yet added to GIT and SVN specific implementations.
+
+        * Scripts/webkitpy/common/checkout/scm/scm.py:
+        (SCM.untracked_files):
+        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
+        (SCMTest._shared_test_untracked_files):
+
 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

@@ -205 +205 @@
         self._subclass_must_implement()
 
+    def untracked_files(self, include_ignored_files=False):
+        self._subclass_must_implement()
+
     def discard_working_directory_changes(self):
         self._subclass_must_implement()

trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py

@@ -310 +310 @@
         os.chdir(old_cwd)
 
+    def _shared_test_untracked_files(self, scm):
+        write_into_file_at_path("test_file_new", "new content")
+        self.assertItemsEqual(scm.untracked_files(), ["test_file_new"])
+
+        os.mkdir("test_dir_new")
+        write_into_file_at_path(os.path.join("test_dir_new", "test_file_new"), "new stuff")
+        self.assertItemsEqual(scm.untracked_files(), ["test_dir_new", "test_file_new"])
+
+        old_cwd = os.getcwd()
+        os.chdir("test_dir_new")
+        # Validate that untracked_files do not change with our cwd.
+        self.assertItemsEqual(scm.untracked_files(), ["test_dir_new", "test_file_new"])
+
+        os.chdir(old_cwd)
+
+        write_into_file_at_path("test_file_new.pyc", "new ignored file")
+        self.assertItemsEqual(scm.untracked_files(), ["test_dir_new", "test_file_new"])
+        self.assertItemsEqual(scm.untracked_files(include_ignored_files=True), ["test_file_new.pyc", "test_dir_new", "test_file_new"])
+
+        shutil.rmtree("test_dir_new")
+        os.remove("test_file_new")
+        os.remove("test_file_new.pyc")
+
     def _shared_test_added_files(self):
         write_into_file_at_path("test_file", "changed content")