⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 195412 in webkit


Ignore:
Timestamp:
Jan 21, 2016, 10:25:02 AM (11 years ago)
Author:
adachan@apple.com
Message:

Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
​https://bugs.webkit.org/show_bug.cgi?id=153218

Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. Code refactoring.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:

Move WebVideoFullscreenInterface.h from ios to cocoa.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitSupportsPresentationMode):
The declaration of supportsPictureInPicture() has been moved to WebVideoFullscreenInterface.h
so include that header instead. Guard the supportsPictureInPicture() call with PLATFORM(COCOA)
as that method is only defined in Cocoa.

  • platform/cocoa/WebVideoFullscreenInterface.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenInterface.h.

Also move the declaration of supportsPictureInPicture() here.

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

Implementations of methods related to the video fullscreen layer are now guarded by

PLATFORM(IOS)
(PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)) instead.
  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:

Declaration of supportsPictureInPicture() has been moved to WebVideoFullscreenInterface.h

  • platform/mac/WebVideoFullscreenInterfaceMac.mm: Added.

(WebCore::supportsPictureInPicture):
Return false for now.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/Platform.h:
Location:
trunk/Source
Files:
1 added
16 edited
1 moved

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r195407 r195412  
     12016-01-19  Ada Chan  <adachan@apple.com>
     2
     3        Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
     4        https://bugs.webkit.org/show_bug.cgi?id=153218
     5
     6        Reviewed by Eric Carlson.
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102016-01-21  Per Arne Vollan  <peavo@outlook.com>
    211

  • trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig

    r195317 r195412  
    171171ENABLE_VIDEO = ENABLE_VIDEO;
    172172ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
     173ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
     174ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
     175ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
     176ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
    173177ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
    174178ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;

  • trunk/Source/WTF/ChangeLog

    r195395 r195412  
     12016-01-19  Ada Chan  <adachan@apple.com>
     2
     3        Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
     4        https://bugs.webkit.org/show_bug.cgi?id=153218
     5
     6        Reviewed by Eric Carlson.
     7
     8        * wtf/Platform.h:
     9
    1102016-01-19  Filip Pizlo  <fpizlo@apple.com>
    211

  • trunk/Source/WTF/wtf/Platform.h

    r195079 r195412  
    11371137#endif
    11381138
    1139 #if PLATFORM(IOS)
     1139#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)
    11401140#define ENABLE_VIDEO_PRESENTATION_MODE 1
    11411141#endif

  • trunk/Source/WebCore/ChangeLog

    r195411 r195412  
     12016-01-19  Ada Chan  <adachan@apple.com>
     2
     3        Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
     4        https://bugs.webkit.org/show_bug.cgi?id=153218
     5
     6        Reviewed by Eric Carlson.
     7
     8        No new tests. Code refactoring.
     9
     10        * Configurations/FeatureDefines.xcconfig:
     11        * WebCore.xcodeproj/project.pbxproj:
     12        Move WebVideoFullscreenInterface.h from ios to cocoa.
     13        * html/HTMLVideoElement.cpp:
     14        (WebCore::HTMLVideoElement::webkitSupportsPresentationMode):
     15        The declaration of supportsPictureInPicture() has been moved to WebVideoFullscreenInterface.h
     16        so include that header instead. Guard the supportsPictureInPicture() call with PLATFORM(COCOA)
     17        as that method is only defined in Cocoa.
     18        * platform/cocoa/WebVideoFullscreenInterface.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenInterface.h.
     19        Also move the declaration of supportsPictureInPicture() here.
     20        * platform/graphics/MediaPlayer.cpp:
     21        * platform/graphics/MediaPlayer.h:
     22        * platform/graphics/MediaPlayerPrivate.h:
     23        Implementations of methods related to the video fullscreen layer are now guarded by
     24        PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)) instead.
     25        * platform/ios/WebVideoFullscreenInterfaceAVKit.h:
     26        Declaration of supportsPictureInPicture() has been moved to WebVideoFullscreenInterface.h
     27        * platform/mac/WebVideoFullscreenInterfaceMac.mm: Added.
     28        (WebCore::supportsPictureInPicture):
     29        Return false for now.
     30
    1312016-01-21  Said Abou-Hallawa  <sabouhallawa@apple.com>
    232

  • trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig

    r195317 r195412  
    171171ENABLE_VIDEO = ENABLE_VIDEO;
    172172ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
     173ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
     174ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
     175ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
     176ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
    173177ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
    174178ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r195410 r195412  
    14711471                3F42B31E1881191B00278AAC /* WebVideoFullscreenControllerAVKit.mm in Sources */ = {isa = PBXBuildFile; fileRef = 3F42B31C1881191B00278AAC /* WebVideoFullscreenControllerAVKit.mm */; };
    14721472                3FBC4AEA189880EF0046EE38 /* WebVideoFullscreenModel.h in Headers */ = {isa = PBXBuildFile; fileRef = 3FBC4AE9189880EF0046EE38 /* WebVideoFullscreenModel.h */; settings = {ATTRIBUTES = (Private, ); }; };
    1473                 3FBC4AEC1898810E0046EE38 /* WebVideoFullscreenInterface.h in Headers */ = {isa = PBXBuildFile; fileRef = 3FBC4AEB1898810E0046EE38 /* WebVideoFullscreenInterface.h */; settings = {ATTRIBUTES = (Private, ); }; };
    14741473                3FBC4AF3189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.mm in Sources */ = {isa = PBXBuildFile; fileRef = 3FBC4AF1189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.mm */; };
    14751474                3FBC4AF4189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.h in Headers */ = {isa = PBXBuildFile; fileRef = 3FBC4AF2189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.h */; settings = {ATTRIBUTES = (Private, ); }; };
    … …  
    22542253                51FB67DB1AE6B82B00D06C5A /* ContentExtensionStyleSheet.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51FB67D91AE6B5E400D06C5A /* ContentExtensionStyleSheet.cpp */; };
    22552254                51FB67DC1AE6B82F00D06C5A /* ContentExtensionStyleSheet.h in Headers */ = {isa = PBXBuildFile; fileRef = 51FB67DA1AE6B5E400D06C5A /* ContentExtensionStyleSheet.h */; settings = {ATTRIBUTES = (Private, ); }; };
     2255                52131E591C4F15350033F802 /* WebVideoFullscreenInterface.h in Headers */ = {isa = PBXBuildFile; fileRef = 52131E581C4F15220033F802 /* WebVideoFullscreenInterface.h */; settings = {ATTRIBUTES = (Private, ); }; };
     2256                52131E5B1C4F15760033F802 /* WebVideoFullscreenInterfaceMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 52131E5A1C4F15610033F802 /* WebVideoFullscreenInterfaceMac.mm */; };
    22562257                521D46F611AEC98100514613 /* KillRingMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 521D46F511AEC98100514613 /* KillRingMac.mm */; };
    22572258                521D46F811AEC9B100514613 /* KillRing.h in Headers */ = {isa = PBXBuildFile; fileRef = 521D46F711AEC9B100514613 /* KillRing.h */; };
    … …  
    88468847                3F42B31C1881191B00278AAC /* WebVideoFullscreenControllerAVKit.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebVideoFullscreenControllerAVKit.mm; sourceTree = "<group>"; };
    88478848                3FBC4AE9189880EF0046EE38 /* WebVideoFullscreenModel.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebVideoFullscreenModel.h; sourceTree = "<group>"; };
    8848                 3FBC4AEB1898810E0046EE38 /* WebVideoFullscreenInterface.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebVideoFullscreenInterface.h; sourceTree = "<group>"; };
    88498849                3FBC4AF1189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebVideoFullscreenInterfaceAVKit.mm; sourceTree = "<group>"; };
    88508850                3FBC4AF2189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebVideoFullscreenInterfaceAVKit.h; sourceTree = "<group>"; };
    … …  
    97179717                51FB67D91AE6B5E400D06C5A /* ContentExtensionStyleSheet.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ContentExtensionStyleSheet.cpp; sourceTree = "<group>"; };
    97189718                51FB67DA1AE6B5E400D06C5A /* ContentExtensionStyleSheet.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ContentExtensionStyleSheet.h; sourceTree = "<group>"; };
     9719                52131E581C4F15220033F802 /* WebVideoFullscreenInterface.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebVideoFullscreenInterface.h; sourceTree = "<group>"; };
     9720                52131E5A1C4F15610033F802 /* WebVideoFullscreenInterfaceMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebVideoFullscreenInterfaceMac.mm; sourceTree = "<group>"; };
    97199721                521D46F511AEC98100514613 /* KillRingMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = KillRingMac.mm; sourceTree = "<group>"; };
    97209722                521D46F711AEC9B100514613 /* KillRing.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = KillRing.h; sourceTree = "<group>"; };
    … …  
    1764117643                                CD8203081395AB6A00F956C6 /* WebVideoFullscreenHUDWindowController.h */,
    1764217644                                CD8203091395AB6A00F956C6 /* WebVideoFullscreenHUDWindowController.mm */,
     17645                                52131E5A1C4F15610033F802 /* WebVideoFullscreenInterfaceMac.mm */,
    1764317646                                CD82030E1395ACE700F956C6 /* WebWindowAnimation.h */,
    1764417647                                CD82030F1395ACE700F956C6 /* WebWindowAnimation.mm */,
    … …  
    1971219715                                3F42B31B1881191B00278AAC /* WebVideoFullscreenControllerAVKit.h */,
    1971319716                                3F42B31C1881191B00278AAC /* WebVideoFullscreenControllerAVKit.mm */,
    19714                                 3FBC4AEB1898810E0046EE38 /* WebVideoFullscreenInterface.h */,
    1971519717                                3FBC4AF2189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.h */,
    1971619718                                3FBC4AF1189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.mm */,
    … …  
    1975319755                                CDC979F21C498C0900DB50D4 /* WebCoreNSErrorExtras.mm */,
    1975419756                                CDC979F31C498C0900DB50D4 /* WebCoreNSErrorExtras.h */,
     19757                                52131E581C4F15220033F802 /* WebVideoFullscreenInterface.h */,
    1975519758                        );
    1975619759                        path = cocoa;
    … …  
    2816228165                                3F42B31D1881191B00278AAC /* WebVideoFullscreenControllerAVKit.h in Headers */,
    2816328166                                CD82030C1395AB6A00F956C6 /* WebVideoFullscreenHUDWindowController.h in Headers */,
    28164                                 3FBC4AEC1898810E0046EE38 /* WebVideoFullscreenInterface.h in Headers */,
     28167                                52131E591C4F15350033F802 /* WebVideoFullscreenInterface.h in Headers */,
    2816528168                                3FBC4AF4189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.h in Headers */,
    2816628169                                3FBC4AEA189880EF0046EE38 /* WebVideoFullscreenModel.h in Headers */,
    … …  
    3157331576                                CD82030D1395AB6A00F956C6 /* WebVideoFullscreenHUDWindowController.mm in Sources */,
    3157431577                                3FBC4AF3189881560046EE38 /* WebVideoFullscreenInterfaceAVKit.mm in Sources */,
     31578                                52131E5B1C4F15760033F802 /* WebVideoFullscreenInterfaceMac.mm in Sources */,
    3157531579                                65FD466619B596F6001E2B4D /* WebVideoFullscreenModelVideoElement.mm in Sources */,
    3157631580                                F12171F516A8CED2000053CA /* WebVTTElement.cpp in Sources */,

  • trunk/Source/WebCore/html/HTMLVideoElement.cpp

    r194496 r195412  
    4646
    4747#if ENABLE(VIDEO_PRESENTATION_MODE)
    48 #include "WebVideoFullscreenInterfaceAVKit.h"
     48#include "WebVideoFullscreenInterface.h"
    4949#endif
    5050
    … …  
    374374        return mediaSession().fullscreenPermitted(*this) && supportsFullscreen();
    375375
    376     if (mode == presentationModePictureInPicture())
    377         return supportsPictureInPicture() && mediaSession().allowsPictureInPicture(*this) && supportsFullscreen();
     376    if (mode == presentationModePictureInPicture()) {
     377#if PLATFORM(COCOA)
     378        if (!supportsPictureInPicture())
     379            return false;
     380#endif
     381
     382        return mediaSession().allowsPictureInPicture(*this) && supportsFullscreen();
     383    }
    378384
    379385    if (mode == presentationModeInline())

  • trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenInterface.h

    r195411 r195412  
    11/*
    2  * Copyright (C) 2014 Apple Inc. All rights reserved.
     2 * Copyright (C) 2014-2016 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    2424 */
    2525
    26 
    2726#ifndef WebVideoFullscreenInterface_h
    2827#define WebVideoFullscreenInterface_h
    2928
    30 #if PLATFORM(IOS)
     29#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
    3130
    3231#include <wtf/Vector.h>
    … …  
    3736
    3837namespace WebCore {
    39    
     38
     39bool supportsPictureInPicture();
     40
     41#if PLATFORM(IOS)
    4042class TimeRanges;
    4143
    … …  
    4850    virtual void setDuration(double) = 0;
    4951    virtual void setCurrentTime(double currentTime, double anchorTime) = 0;
    50     virtual void setBufferedTime(double bufferedTime) = 0;
     52    virtual void setBufferedTime(double) = 0;
    5153    virtual void setRate(bool isPlaying, float playbackRate) = 0;
    5254    virtual void setVideoDimensions(bool hasVideo, float width, float height) = 0;
    … …  
    5860    virtual void setWirelessVideoPlaybackDisabled(bool) = 0;
    5961};
     62#endif
    6063
    6164}

  • trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp

    r194819 r195412  
    644644}
    645645   
     646#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
     647void MediaPlayer::setVideoFullscreenLayer(PlatformLayer* layer)
     648{
     649    m_private->setVideoFullscreenLayer(layer);
     650}
     651
     652void MediaPlayer::setVideoFullscreenFrame(FloatRect frame)
     653{
     654    m_private->setVideoFullscreenFrame(frame);
     655}
     656
     657void MediaPlayer::setVideoFullscreenGravity(MediaPlayer::VideoGravity gravity)
     658{
     659    m_private->setVideoFullscreenGravity(gravity);
     660}
     661
     662void MediaPlayer::setVideoFullscreenMode(MediaPlayer::VideoFullscreenMode mode)
     663{
     664    m_private->setVideoFullscreenMode(mode);
     665}
     666
     667MediaPlayer::VideoFullscreenMode MediaPlayer::fullscreenMode() const
     668{
     669    return m_client.mediaPlayerFullscreenMode();
     670}
     671#endif
     672
    646673#if PLATFORM(IOS)
    647 void MediaPlayer::setVideoFullscreenLayer(PlatformLayer* layer)
    648 {
    649     m_private->setVideoFullscreenLayer(layer);
    650 }
    651 
    652 void MediaPlayer::setVideoFullscreenFrame(FloatRect frame)
    653 {
    654     m_private->setVideoFullscreenFrame(frame);
    655 }
    656 
    657 void MediaPlayer::setVideoFullscreenGravity(MediaPlayer::VideoGravity gravity)
    658 {
    659     m_private->setVideoFullscreenGravity(gravity);
    660 }
    661 
    662 void MediaPlayer::setVideoFullscreenMode(MediaPlayer::VideoFullscreenMode mode)
    663 {
    664     m_private->setVideoFullscreenMode(mode);
    665 }
    666 
    667 MediaPlayer::VideoFullscreenMode MediaPlayer::fullscreenMode() const
    668 {
    669     return m_client.mediaPlayerFullscreenMode();
    670 }
    671 
    672674NSArray* MediaPlayer::timedMetadata() const
    673675{

  • trunk/Source/WebCore/platform/graphics/MediaPlayer.h

    r193479 r195412  
    309309    PlatformMedia platformMedia() const;
    310310    PlatformLayer* platformLayer() const;
    311 #if PLATFORM(IOS)
     311
     312#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
    312313    void setVideoFullscreenLayer(PlatformLayer*);
    313314    void setVideoFullscreenFrame(FloatRect);
    … …  
    316317    void setVideoFullscreenMode(VideoFullscreenMode);
    317318    VideoFullscreenMode fullscreenMode() const;
    318 
     319#endif
     320
     321#if PLATFORM(IOS)
    319322    NSArray *timedMetadata() const;
    320323    String accessLog() const;

  • trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h

    r193479 r195412  
    5858    virtual PlatformMedia platformMedia() const { return NoPlatformMedia; }
    5959    virtual PlatformLayer* platformLayer() const { return 0; }
    60 #if PLATFORM(IOS)
     60
     61#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
    6162    virtual void setVideoFullscreenLayer(PlatformLayer*) { }
    6263    virtual void setVideoFullscreenFrame(FloatRect) { }
    6364    virtual void setVideoFullscreenGravity(MediaPlayer::VideoGravity) { }
    6465    virtual void setVideoFullscreenMode(MediaPlayer::VideoFullscreenMode) { }
    65 
     66#endif
     67
     68#if PLATFORM(IOS)
    6669    virtual NSArray *timedMetadata() const { return 0; }
    6770    virtual String accessLog() const { return emptyString(); }

  • trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h

    r193340 r195412  
    162162};
    163163
    164 bool supportsPictureInPicture();
    165 
    166164}
    167165

  • trunk/Source/WebKit/mac/ChangeLog

    r195327 r195412  
     12016-01-19  Ada Chan  <adachan@apple.com>
     2
     3        Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
     4        https://bugs.webkit.org/show_bug.cgi?id=153218
     5
     6        Reviewed by Eric Carlson.
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102016-01-19  Beth Dakin  <bdakin@apple.com>
    211

  • trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig

    r195317 r195412  
    171171ENABLE_VIDEO = ENABLE_VIDEO;
    172172ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
     173ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
     174ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
     175ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
     176ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
    173177ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
    174178ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;

  • trunk/Source/WebKit2/ChangeLog

    r195358 r195412  
     12016-01-19  Ada Chan  <adachan@apple.com>
     2
     3        Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
     4        https://bugs.webkit.org/show_bug.cgi?id=153218
     5
     6        Reviewed by Eric Carlson.
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102016-01-20  Alex Christensen  <achristensen@webkit.org>
    211

  • trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig

    r195317 r195412  
    171171ENABLE_VIDEO = ENABLE_VIDEO;
    172172ENABLE_VIDEO_PRESENTATION_MODE[sdk=iphone*] = ENABLE_VIDEO_PRESENTATION_MODE;
     173ENABLE_VIDEO_PRESENTATION_MODE[sdk=macosx*] = $(ENABLE_VIDEO_PRESENTATION_MODE_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR))
     174ENABLE_VIDEO_PRESENTATION_MODE_macosx_101000 = ;
     175ENABLE_VIDEO_PRESENTATION_MODE_macosx_101100 = ;
     176ENABLE_VIDEO_PRESENTATION_MODE_macosx_101200 = ENABLE_VIDEO_PRESENTATION_MODE;
    173177ENABLE_VIDEO_TRACK = ENABLE_VIDEO_TRACK;
    174178ENABLE_DATACUE_VALUE = ENABLE_DATACUE_VALUE;
Note: See TracChangeset for help on using the changeset viewer.