Changeset 195418 in webkit

Timestamp:

Jan 21, 2016, 12:15:04 PM (11 years ago)

Author:

fpizlo@apple.com

Message:

Move32 should have an Imm, Tmp form
​https://bugs.webkit.org/show_bug.cgi?id=153313

Reviewed by Mark Lam.

This enables some useful optimizations, like constant propagation in fixObviousSpills().

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
(JSC::MacroAssemblerX86Common::move):

• b3/air/AirOpcode.opcodes:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssemblerX86Common.h (modified) (1 diff)
• b3/air/AirOpcode.opcodes (modified) (1 diff)
• dfg/DFGCommon.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-01-21  Filip Pizlo  <fpizlo@apple.com>
+
+        Move32 should have an Imm, Tmp form
+        https://bugs.webkit.org/show_bug.cgi?id=153313
+
+        Reviewed by Mark Lam.
+
+        This enables some useful optimizations, like constant propagation in fixObviousSpills().
+
+        * assembler/MacroAssemblerX86Common.h:
+        (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
+        (JSC::MacroAssemblerX86Common::move):
+        * b3/air/AirOpcode.opcodes:
+
 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h

@@ -1351 +1351 @@
     {
         m_assembler.movl_rr(src, dest);
+    }
+
+    void zeroExtend32ToPtr(TrustedImm32 src, RegisterID dest)
+    {
+        m_assembler.movl_i32r(src.m_value, dest);
     }
 #else

trunk/Source/JavaScriptCore/b3/air/AirOpcode.opcodes

@@ -432 +432 @@
     Tmp, Addr as store32
     Tmp, Index as store32
+    x86: Imm, Tmp as zeroExtend32ToPtr
     x86: Imm, Addr as store32
     x86: Imm, Index as store32

trunk/Source/JavaScriptCore/dfg/DFGCommon.h

@@ -39 +39 @@
 // yet know how it will turn out. For now, this flag will control whether FTL uses B3. Remember to set this
 // to 0 before committing!
-#define FTL_USES_B3 0
+#define FTL_USES_B3 1
 
 struct Node;