Changeset 19567 in webkit


Ignore:
Timestamp:
Feb 11, 2007, 4:18:21 PM (18 years ago)
Author:
antti
Message:

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: Google Calendar cell highlight misplaced
http://bugs.webkit.org/show_bug.cgi?id=12687

  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders.html: Added.

WebCore:

Reviewed by Maciej.


REGRESSION: Google Calendar cell highlight misplaced
http://bugs.webkit.org/show_bug.cgi?id=12687


Make offsetLeft/offsetTop/offsetParent behavior match Firefox.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): (WebCore::RenderObject::offsetTop): (WebCore::RenderObject::offsetParent):
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • TabularUnified trunk/LayoutTests/ChangeLog

    r19566 r19567  
     12007-02-12  Antti Koivisto  <antti@apple.com>
     2
     3        Reviewed by Maciej.
     4       
     5        Test for REGRESSION: Google Calendar cell highlight misplaced
     6        http://bugs.webkit.org/show_bug.cgi?id=12687
     7
     8        * fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Added.
     9        * fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Added.
     10        * fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Added.
     11        * fast/block/positioning/offsetLeft-offsetTop-borders.html: Added.
     12
    1132007-02-11  Antti Koivisto  <antti@apple.com>
    214
  • TabularUnified trunk/WebCore/ChangeLog

    r19566 r19567  
     12007-02-12  Antti Koivisto  <antti@apple.com>
     2
     3        Reviewed by Maciej.
     4       
     5        REGRESSION: Google Calendar cell highlight misplaced
     6        http://bugs.webkit.org/show_bug.cgi?id=12687
     7       
     8        Make offsetLeft/offsetTop/offsetParent behavior match Firefox.
     9
     10        * rendering/RenderObject.cpp:
     11        (WebCore::RenderObject::offsetLeft):
     12        (WebCore::RenderObject::offsetTop):
     13        (WebCore::RenderObject::offsetParent):
     14
    1152007-02-10  Antti Koivisto  <antti@apple.com>
    216
  • TabularUnified trunk/WebCore/rendering/RenderObject.cpp

    r19490 r19567  
    508508    if (!offsetPar)
    509509        return 0;
    510     int x = xPos();
     510    int x = xPos() - offsetPar->borderLeft();
    511511    if (!isPositioned()) {
    512512        if (isRelPositioned())
     
    528528    if (!offsetPar)
    529529        return 0;
    530     int y = yPos();
     530    int y = yPos() - offsetPar->borderTop();
    531531    if (!isPositioned()) {
    532532        if (isRelPositioned())
     
    553553    RenderObject* curr = parent();
    554554    while (curr && (!curr->element() ||
    555                     (!curr->isPositioned() && !curr->isRelPositioned() &&
    556                         !(!style()->htmlHacks() && skipTables ? curr->isRoot() : curr->isBody())))) {
    557         if (!skipTables && curr->element() && (curr->isTableCell() || curr->isTable()))
     555                    (!curr->isPositioned() && !curr->isRelPositioned() && !curr->isBody()))) {
     556        if (!skipTables && curr->element() && (curr->element()->hasTagName(tableTag) ||
     557                                               curr->element()->hasTagName(tdTag) || curr->element()->hasTagName(thTag)))
    558558            break;
    559559        curr = curr->parent();
Note: See TracChangeset for help on using the changeset viewer.