Changeset 19622 in webkit


Ignore:
Timestamp:
Feb 14, 2007 9:13:32 AM (17 years ago)
Author:
ggaren
Message:

Reviewed by Beth Dakin.


Blind attempt to make this test more reliable. (It fails intermittently
on the buildbot.)

  • editing/execCommand/find-after-replace-expected.checksum:
  • editing/execCommand/find-after-replace-expected.png:
  • editing/execCommand/find-after-replace-expected.txt:
  • editing/execCommand/find-after-replace.html: Use a load event handler instead of a 100ms timer. There's no guarantee that everything will be done loading in under 100ms (and there's no reason to wait that long all the time, either!).
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r19621 r19622  
     12007-02-14  Geoffrey Garen  <ggaren@apple.com>
     2
     3        Reviewed by Beth Dakin.
     4       
     5        Blind attempt to make this test more reliable. (It fails intermittently
     6        on the buildbot.)
     7
     8        * editing/execCommand/find-after-replace-expected.checksum:
     9        * editing/execCommand/find-after-replace-expected.png:
     10        * editing/execCommand/find-after-replace-expected.txt:
     11        * editing/execCommand/find-after-replace.html: Use a load event handler
     12        instead of a 100ms timer. There's no guarantee that everything will be
     13        done loading in under 100ms (and there's no reason to wait that long all
     14        the time, either!).
     15
    1162007-02-14  Mitz Pettel  <mitz@webkit.org>
    217

  • trunk/LayoutTests/editing/execCommand/find-after-replace-expected.checksum

    r18953 r19622  
    1 5a0bfef92ff7528e42106cea8dde4577
     1dcb24bbc2bafc4c7b553a7048ccccb8e

  • trunk/LayoutTests/editing/execCommand/find-after-replace-expected.txt

    r19034 r19622  
    77EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    88EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 4 of #text > BODY > HTML > #document to 5 of #text > BODY > HTML > #document givenAction:WebViewInsertActionPasted
    9 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > BODY > HTML > #document to 0 of #text > BODY > HTML > #document toDOMRange:range from 3 of #text > BODY > HTML > #document to 3 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     9EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of #text > BODY > HTML > #document to 0 of #text > BODY > HTML > #document toDOMRange:range from 3 of #text > BODY > HTML > #document to 3 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    1010EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    1111EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    … …  
    2727            RenderBlock {HTML} at (0,0) size 300x150
    2828              RenderBody {BODY} at (8,8) size 284x134 [bgcolor=#FFFFE0]
    29                 RenderText {#text} at (0,0) size 31x18
    30                   text run at (0,0) width 31: "A B "
    31                 RenderText {#text} at (31,0) size 27x18
    32                   text run at (31,0) width 27: "A B"
     29                RenderText {#text} at (0,0) size 27x18
     30                  text run at (0,0) width 27: "A B"
     31                RenderText {#text} at (27,0) size 27x18
     32                  text run at (27,0) width 27: "A B"
     33                RenderText {#text} at (54,0) size 4x18
     34                  text run at (54,0) width 4: " "
    3335        RenderText {#text} at (0,0) size 0x0
    3436        RenderText {#text} at (0,0) size 0x0

  • trunk/LayoutTests/editing/execCommand/find-after-replace.html

    r18953 r19622  
    1 <script>
    2 if (window.layoutTestController)
    3      layoutTestController.dumpEditingCallbacks();
    4 </script>
    51<p>This tests find and replace inside an editable iframe.  You should see 'A B A B' below. With bug 4462420, you would see 'A B B A'.</p>
    62<iframe src="../resources/contenteditable-iframe-src.html"></iframe>
    73
    84<script>
    9 function runTest() {
     5if (window.layoutTestController) {
     6    layoutTestController.dumpEditingCallbacks();
     7    layoutTestController.waitUntilDone();
     8}
     9
     10window.onload = function onload() {
    1011    var frame = frames[0];
    1112    var sel = frame.getSelection();
    … …  
    1920    doc.execCommand("FindString", false, "A");
    2021    doc.execCommand("Paste");
     22
    2123    if (window.layoutTestController)
    2224        window.layoutTestController.notifyDone();
    2325}
    24 if (window.layoutTestController)
    25     window.layoutTestController.waitUntilDone();
    26 window.setTimeout(runTest, 100);
    2726</script>
Note: See TracChangeset for help on using the changeset viewer.