Changeset 196999 in webkit

Timestamp:

Feb 23, 2016, 2:41:26 PM (11 years ago)

Author:

sbarati@apple.com

Message:

Make JSObject::getMethod have fewer branches
​https://bugs.webkit.org/show_bug.cgi?id=154603

Reviewed by Mark Lam.

Writing code with fewer branches is almost always better.

• runtime/JSObject.cpp:

(JSC::JSObject::getMethod):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-02-23  Saam barati  <sbarati@apple.com>
+
+        Make JSObject::getMethod have fewer branches
+        https://bugs.webkit.org/show_bug.cgi?id=154603
+
+        Reviewed by Mark Lam.
+
+        Writing code with fewer branches is almost always better.
+
+        * runtime/JSObject.cpp:
+        (JSC::JSObject::getMethod):
+
 2016-02-23  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSObject.cpp

@@ -2948 +2948 @@
         return jsUndefined();
 
-    if (method.isUndefined() || method.isNull())
-        return jsUndefined();
-
     if (!method.isCell()) {
+        if (method.isUndefinedOrNull())
+            return jsUndefined();
+
         throwVMTypeError(exec, errorMessage);
         return jsUndefined();