⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 197105 in webkit


Ignore:
Timestamp:
Feb 25, 2016, 5:56:57 AM (11 years ago)
Author:
Carlos Garcia Campos
Message:

Merge r196977 - [SVG] Update SVG source to return string literals as ASCIILiteral and add test cases for case sensitivity
​https://bugs.webkit.org/show_bug.cgi?id=154373

Patch by Nikos Andronikos <​nikos.andronikos-webkit@cisra.canon.com.au> on 2016-02-23
Reviewed by Youenn Fablet.

Source/WebCore:

Update SVGAnimatedEnumeration toString method to return ASCIILiteral for string literals and add test cases for
case-sensitivity for these elements.

Test: svg/dom/SVGAnimatedEnumeration-case-sensitive.html

  • svg/SVGComponentTransferFunctionElement.h:

(WebCore::SVGPropertyTraits<ComponentTransferType>::toString):

  • svg/SVGFEBlendElement.h:

(WebCore::SVGPropertyTraits<BlendMode>::toString):

  • svg/SVGFEColorMatrixElement.h:

(WebCore::SVGPropertyTraits<ColorMatrixType>::toString):

  • svg/SVGFECompositeElement.h:

(WebCore::SVGPropertyTraits<CompositeOperationType>::toString):

  • svg/SVGFEConvolveMatrixElement.h:

(WebCore::SVGPropertyTraits<EdgeModeType>::toString):

  • svg/SVGFEDisplacementMapElement.h:

(WebCore::SVGPropertyTraits<ChannelSelectorType>::toString):

  • svg/SVGFEMorphologyElement.h:

(WebCore::SVGPropertyTraits<MorphologyOperatorType>::toString):

  • svg/SVGFETurbulenceElement.h:

(WebCore::SVGPropertyTraits<SVGStitchOptions>::toString):
(WebCore::SVGPropertyTraits<TurbulenceType>::toString):

  • svg/SVGGradientElement.h:

(WebCore::SVGPropertyTraits<SVGSpreadMethodType>::toString):

  • svg/SVGMarkerElement.h:

(WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::toString):

  • svg/SVGTextContentElement.h:

(WebCore::SVGPropertyTraits<SVGLengthAdjustType>::toString):

  • svg/SVGTextPathElement.h:

(WebCore::SVGPropertyTraits<SVGTextPathMethodType>::toString):
(WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):

  • svg/SVGUnitTypes.h:

(WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::toString):

LayoutTests:

Add test cases for case-sensitivity for SVGAnimatedEnumeration elements.

  • svg/dom/SVGAnimatedEnumeration-case-sensitive-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-case-sensitive.html: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-case-sensitive.js: Added.

(testCaseSensitivity):

Location:
releases/WebKitGTK/webkit-2.12
Files:
3 added
15 edited

Legend:

Unmodified
Added
Removed

  • releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog

    r197103 r197105  
     12016-02-23  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
     2
     3        [SVG] Update SVG source to return string literals as ASCIILiteral and add test cases for case sensitivity
     4        https://bugs.webkit.org/show_bug.cgi?id=154373
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Add test cases for case-sensitivity for SVGAnimatedEnumeration elements.
     9
     10        * svg/dom/SVGAnimatedEnumeration-case-sensitive-expected.txt: Added.
     11        * svg/dom/SVGAnimatedEnumeration-case-sensitive.html: Added.
     12        * svg/dom/script-tests/SVGAnimatedEnumeration-case-sensitive.js: Added.
     13        (testCaseSensitivity):
     14
    1152016-02-22  Myles C. Maxfield  <mmaxfield@apple.com>
    216

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog

    r197104 r197105  
     12016-02-23  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
     2
     3        [SVG] Update SVG source to return string literals as ASCIILiteral and add test cases for case sensitivity
     4        https://bugs.webkit.org/show_bug.cgi?id=154373
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Update SVGAnimatedEnumeration toString method to return ASCIILiteral for string literals and add test cases for
     9        case-sensitivity for these elements.
     10
     11        Test: svg/dom/SVGAnimatedEnumeration-case-sensitive.html
     12
     13        * svg/SVGComponentTransferFunctionElement.h:
     14        (WebCore::SVGPropertyTraits<ComponentTransferType>::toString):
     15        * svg/SVGFEBlendElement.h:
     16        (WebCore::SVGPropertyTraits<BlendMode>::toString):
     17        * svg/SVGFEColorMatrixElement.h:
     18        (WebCore::SVGPropertyTraits<ColorMatrixType>::toString):
     19        * svg/SVGFECompositeElement.h:
     20        (WebCore::SVGPropertyTraits<CompositeOperationType>::toString):
     21        * svg/SVGFEConvolveMatrixElement.h:
     22        (WebCore::SVGPropertyTraits<EdgeModeType>::toString):
     23        * svg/SVGFEDisplacementMapElement.h:
     24        (WebCore::SVGPropertyTraits<ChannelSelectorType>::toString):
     25        * svg/SVGFEMorphologyElement.h:
     26        (WebCore::SVGPropertyTraits<MorphologyOperatorType>::toString):
     27        * svg/SVGFETurbulenceElement.h:
     28        (WebCore::SVGPropertyTraits<SVGStitchOptions>::toString):
     29        (WebCore::SVGPropertyTraits<TurbulenceType>::toString):
     30        * svg/SVGGradientElement.h:
     31        (WebCore::SVGPropertyTraits<SVGSpreadMethodType>::toString):
     32        * svg/SVGMarkerElement.h:
     33        (WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::toString):
     34        * svg/SVGTextContentElement.h:
     35        (WebCore::SVGPropertyTraits<SVGLengthAdjustType>::toString):
     36        * svg/SVGTextPathElement.h:
     37        (WebCore::SVGPropertyTraits<SVGTextPathMethodType>::toString):
     38        (WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):
     39        * svg/SVGUnitTypes.h:
     40        (WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::toString):
     41
    1422016-02-22  Gavin Barraclough  <barraclough@apple.com>
    243

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGComponentTransferFunctionElement.h

    r182121 r197105  
    3939            return emptyString();
    4040        case FECOMPONENTTRANSFER_TYPE_IDENTITY:
    41             return "identity";
     41            return ASCIILiteral("identity");
    4242        case FECOMPONENTTRANSFER_TYPE_TABLE:
    43             return "table";
     43            return ASCIILiteral("table");
    4444        case FECOMPONENTTRANSFER_TYPE_DISCRETE:
    45             return "discrete";
     45            return ASCIILiteral("discrete");
    4646        case FECOMPONENTTRANSFER_TYPE_LINEAR:
    47             return "linear";
     47            return ASCIILiteral("linear");
    4848        case FECOMPONENTTRANSFER_TYPE_GAMMA:
    49             return "gamma";
     49            return ASCIILiteral("gamma");
    5050        }
    5151

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGFEBlendElement.h

    r183381 r197105  
    3737        switch (type) {
    3838        case BlendModeNormal:
    39             return "normal";
     39            return ASCIILiteral("normal");
    4040        case BlendModeMultiply:
    41             return "multiply";
     41            return ASCIILiteral("multiply");
    4242        case BlendModeScreen:
    43             return "screen";
     43            return ASCIILiteral("screen");
    4444        case BlendModeDarken:
    45             return "darken";
     45            return ASCIILiteral("darken");
    4646        case BlendModeLighten:
    47             return "lighten";
     47            return ASCIILiteral("lighten");
    4848        default:
    4949            return emptyString();

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGFEColorMatrixElement.h

    r183381 r197105  
    3939            return emptyString();
    4040        case FECOLORMATRIX_TYPE_MATRIX:
    41             return "matrix";
     41            return ASCIILiteral("matrix");
    4242        case FECOLORMATRIX_TYPE_SATURATE:
    43             return "saturate";
     43            return ASCIILiteral("saturate");
    4444        case FECOLORMATRIX_TYPE_HUEROTATE:
    45             return "hueRotate";
     45            return ASCIILiteral("hueRotate");
    4646        case FECOLORMATRIX_TYPE_LUMINANCETOALPHA:
    47             return "luminanceToAlpha";
     47            return ASCIILiteral("luminanceToAlpha");
    4848        }
    4949

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGFECompositeElement.h

    r195745 r197105  
    4242            return emptyString();
    4343        case FECOMPOSITE_OPERATOR_OVER:
    44             return "over";
     44            return ASCIILiteral("over");
    4545        case FECOMPOSITE_OPERATOR_IN:
    46             return "in";
     46            return ASCIILiteral("in");
    4747        case FECOMPOSITE_OPERATOR_OUT:
    48             return "out";
     48            return ASCIILiteral("out");
    4949        case FECOMPOSITE_OPERATOR_ATOP:
    50             return "atop";
     50            return ASCIILiteral("atop");
    5151        case FECOMPOSITE_OPERATOR_XOR:
    52             return "xor";
     52            return ASCIILiteral("xor");
    5353        case FECOMPOSITE_OPERATOR_ARITHMETIC:
    54             return "arithmetic";
     54            return ASCIILiteral("arithmetic");
    5555        case FECOMPOSITE_OPERATOR_LIGHTER:
    56             return "lighter";
     56            return ASCIILiteral("lighter");
    5757        }
    5858

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGFEConvolveMatrixElement.h

    r183381 r197105  
    4141            return emptyString();
    4242        case EDGEMODE_DUPLICATE:
    43             return "duplicate";
     43            return ASCIILiteral("duplicate");
    4444        case EDGEMODE_WRAP:
    45             return "wrap";
     45            return ASCIILiteral("wrap");
    4646        case EDGEMODE_NONE:
    47             return "none";
     47            return ASCIILiteral("none");
    4848        }
    4949

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGFEDisplacementMapElement.h

    r183381 r197105  
    3838            return emptyString();
    3939        case CHANNEL_R:
    40             return "R";
     40            return ASCIILiteral("R");
    4141        case CHANNEL_G:
    42             return "G";
     42            return ASCIILiteral("G");
    4343        case CHANNEL_B:
    44             return "B";
     44            return ASCIILiteral("B");
    4545        case CHANNEL_A:
    46             return "A";
     46            return ASCIILiteral("A");
    4747        }
    4848

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGFEMorphologyElement.h

    r183381 r197105  
    3838            return emptyString();
    3939        case FEMORPHOLOGY_OPERATOR_ERODE:
    40             return "erode";
     40            return ASCIILiteral("erode");
    4141        case FEMORPHOLOGY_OPERATOR_DILATE:
    42             return "dilate";
     42            return ASCIILiteral("dilate");
    4343        }
    4444

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGFETurbulenceElement.h

    r183381 r197105  
    4646            return emptyString();
    4747        case SVG_STITCHTYPE_STITCH:
    48             return "stitch";
     48            return ASCIILiteral("stitch");
    4949        case SVG_STITCHTYPE_NOSTITCH:
    50             return "noStitch";
     50            return ASCIILiteral("noStitch");
    5151        }
    5252
    … …  
    7575            return emptyString();
    7676        case FETURBULENCE_TYPE_FRACTALNOISE:
    77             return "fractalNoise";
     77            return ASCIILiteral("fractalNoise");
    7878        case FETURBULENCE_TYPE_TURBULENCE:
    79             return "turbulence";
     79            return ASCIILiteral("turbulence");
    8080        }
    8181

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGGradientElement.h

    r185503 r197105  
    5151            return emptyString();
    5252        case SVGSpreadMethodPad:
    53             return "pad";
     53            return ASCIILiteral("pad");
    5454        case SVGSpreadMethodReflect:
    55             return "reflect";
     55            return ASCIILiteral("reflect");
    5656        case SVGSpreadMethodRepeat:
    57             return "repeat";
     57            return ASCIILiteral("repeat");
    5858        }
    5959

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGMarkerElement.h

    r185503 r197105  
    5959            return emptyString();
    6060        case SVGMarkerUnitsUserSpaceOnUse:
    61             return "userSpaceOnUse";
     61            return ASCIILiteral("userSpaceOnUse");
    6262        case SVGMarkerUnitsStrokeWidth:
    63             return "strokeWidth";
     63            return ASCIILiteral("strokeWidth");
    6464        }
    6565

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGTextContentElement.h

    r185503 r197105  
    4646            return emptyString();
    4747        case SVGLengthAdjustSpacing:
    48             return "spacing";
     48            return ASCIILiteral("spacing");
    4949        case SVGLengthAdjustSpacingAndGlyphs:
    50             return "spacingAndGlyphs";
     50            return ASCIILiteral("spacingAndGlyphs");
    5151        }
    5252

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGTextPathElement.h

    r185813 r197105  
    4949            return emptyString();
    5050        case SVGTextPathMethodAlign:
    51             return "align";
     51            return ASCIILiteral("align");
    5252        case SVGTextPathMethodStretch:
    53             return "stretch";
     53            return ASCIILiteral("stretch");
    5454        }
    5555   
    … …  
    7878            return emptyString();
    7979        case SVGTextPathSpacingAuto:
    80             return "auto";
     80            return ASCIILiteral("auto");
    8181        case SVGTextPathSpacingExact:
    82             return "exact";
     82            return ASCIILiteral("exact");
    8383        }
    8484

  • releases/WebKitGTK/webkit-2.12/Source/WebCore/svg/SVGUnitTypes.h

    r163440 r197105  
    4848            return emptyString();
    4949        case SVGUnitTypes::SVG_UNIT_TYPE_USERSPACEONUSE:
    50             return "userSpaceOnUse";
     50            return ASCIILiteral("userSpaceOnUse");
    5151        case SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX:
    52             return "objectBoundingBox";
     52            return ASCIILiteral("objectBoundingBox");
    5353        }
    5454
Note: See TracChangeset for help on using the changeset viewer.