Changeset 197134 in webkit

Timestamp:

Feb 25, 2016, 2:37:44 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Remove a useless "Move" in the lowering of Select
​https://bugs.webkit.org/show_bug.cgi?id=154670

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-02-25
Reviewed by Geoffrey Garen.

I left the Move instruction when creating the aliasing form
of Select.

On ARM64, that meant a useless move for any case that can't
be coalesced.

On x86, that meant an extra constraint on child2, making it
stupidly hard to alias child1.

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::createSelect): Deleted.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• b3/B3LowerToAir.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-02-25  Benjamin Poulain  <bpoulain@apple.com>
+
+        [JSC] Remove a useless "Move" in the lowering of Select
+        https://bugs.webkit.org/show_bug.cgi?id=154670
+
+        Reviewed by Geoffrey Garen.
+
+        I left the Move instruction when creating the aliasing form
+        of Select.
+
+        On ARM64, that meant a useless move for any case that can't
+        be coalesced.
+
+        On x86, that meant an extra constraint on child2, making it
+        stupidly hard to alias child1.
+
+        * b3/B3LowerToAir.cpp:
+        (JSC::B3::Air::LowerToAir::createSelect): Deleted.
+
 2016-02-24  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/b3/B3LowerToAir.cpp

@@ -1608 +1608 @@
                 Tmp thenCase = tmp(m_value->child(1));
                 Tmp elseCase = tmp(m_value->child(2));
-                append(relaxedMoveForType(m_value->type()), tmp(m_value->child(2)), result);
                 return Inst(
                     opcode, m_value, condition,