Changeset 197638 in webkit

Timestamp:

Mar 6, 2016, 4:04:30 AM (11 years ago)

Author:

akling@apple.com

Message:

Reduce page cache capacity from 3 to 2.
<​https://webkit.org/b/155087>

Reviewed by Antti Koivisto.

Source/WebKit/mac:

Trim WebKit1 page cache capacities consistently with WebKit2.

• WebView/WebView.mm:

(+[WebView _setCacheModel:]):

Source/WebKit2:

It's extremely rare that users go back more than 2 pages in the page cache,
and nowadays the network cache makes even un-cached pages fast to reload.

Trimming the page cache from 3 to 2 entries has a very nice effect on heap
fragmentation. I'm seeing a ~5% progression on the iPad PLUM test locally;
average memory usage across 300 loads goes from ~121MB to ~114MB.

• Shared/CacheModel.cpp:

(WebKit::calculateCacheSizes):

Location:

trunk/Source

Files:

• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebView.mm (modified) (2 diffs)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/CacheModel.cpp (modified) (2 diffs)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-03-06  Andreas Kling  <akling@apple.com>
+
+        Reduce page cache capacity from 3 to 2.
+        <https://webkit.org/b/155087>
+
+        Reviewed by Antti Koivisto.
+
+        Trim WebKit1 page cache capacities consistently with WebKit2.
+
+        * WebView/WebView.mm:
+        (+[WebView _setCacheModel:]):
+
 2016-03-05  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebView.mm

@@ -7880 +7880 @@
     case WebCacheModelDocumentBrowser: {
         // Page cache capacity (in pages)
-        if (memSize >= 1024)
-            pageCacheSize = 3;
-        else if (memSize >= 512)
+        if (memSize >= 512)
             pageCacheSize = 2;
         else if (memSize >= 256)
@@ -7933 +7931 @@
     case WebCacheModelPrimaryWebBrowser: {
         // Page cache capacity (in pages)
-        // Research indicates that value / page drops substantially after 3 pages.
-        if (memSize >= 1024)
-            pageCacheSize = 3;
-        else if (memSize >= 512)
+        if (memSize >= 512)
             pageCacheSize = 2;
         else if (memSize >= 256)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-03-06  Andreas Kling  <akling@apple.com>
+
+        Reduce page cache capacity from 3 to 2.
+        <https://webkit.org/b/155087>
+
+        Reviewed by Antti Koivisto.
+
+        It's extremely rare that users go back more than 2 pages in the page cache,
+        and nowadays the network cache makes even un-cached pages fast to reload.
+
+        Trimming the page cache from 3 to 2 entries has a very nice effect on heap
+        fragmentation. I'm seeing a ~5% progression on the iPad PLUM test locally;
+        average memory usage across 300 loads goes from ~121MB to ~114MB.
+
+        * Shared/CacheModel.cpp:
+        (WebKit::calculateCacheSizes):
+
 2016-03-05  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/Shared/CacheModel.cpp

@@ -63 +63 @@
     case CacheModelDocumentBrowser: {
         // Page cache capacity (in pages)
-        if (memorySize >= 1024)
-            pageCacheCapacity = 3;
-        else if (memorySize >= 512)
+        if (memorySize >= 512)
             pageCacheCapacity = 2;
         else if (memorySize >= 256)
@@ -109 +107 @@
     case CacheModelPrimaryWebBrowser: {
         // Page cache capacity (in pages)
-        if (memorySize >= 1024)
-            pageCacheCapacity = 3;
-        else if (memorySize >= 512)
+        if (memorySize >= 512)
             pageCacheCapacity = 2;
         else if (memorySize >= 256)