Changeset 197806 in webkit

Timestamp:

Mar 8, 2016, 3:02:55 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Miscellaneous inspector fixes for typos / stale code
​https://bugs.webkit.org/show_bug.cgi?id=155193

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-08
Reviewed by Timothy Hatcher.

• UserInterface/Models/SourceCodeLocation.js:

(WebInspector.SourceCodeLocation.prototype._locationString):
Fix whitespace.

• UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView):
Remove unused class name.

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
Remove inferredName, as that was never sent by our backend and is getting removed.

• UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype._handleMouseUp):
Fix variable name typo.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/SourceCodeLocation.js (modified) (1 diff)
• UserInterface/Views/ApplicationCacheFrameContentView.js (modified) (1 diff)
• UserInterface/Views/SourceCodeTextEditor.js (modified) (1 diff)
• UserInterface/Views/TimelineRuler.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-03-08  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Miscellaneous inspector fixes for typos / stale code
+        https://bugs.webkit.org/show_bug.cgi?id=155193
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Models/SourceCodeLocation.js:
+        (WebInspector.SourceCodeLocation.prototype._locationString):
+        Fix whitespace.
+
+        * UserInterface/Views/ApplicationCacheFrameContentView.js:
+        (WebInspector.ApplicationCacheFrameContentView):
+        Remove unused class name.
+
+        * UserInterface/Views/SourceCodeTextEditor.js:
+        (WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
+        Remove inferredName, as that was never sent by our backend and is getting removed.
+
+        * UserInterface/Views/TimelineRuler.js:
+        (WebInspector.TimelineRuler.prototype._handleMouseUp):
+        Fix variable name typo.
+
 2016-03-08  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js

@@ -341 +341 @@
                 return prefix + name;
             let lineSuffix = displayURL ? ":" + lineString : WebInspector.UIString(" (line %s)").format(lineString);
-            return  prefix + name + lineSuffix;
+            return prefix + name + lineSuffix;
 
         default:

trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js

@@ -32 +32 @@
         super(representedObject);
 
-        this.element.classList.add("application-cache-frame", "table");
+        this.element.classList.add("application-cache-frame");
 
         this._frame = representedObject.frame;

trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js

@@ -1476 +1476 @@
             let title = content.appendChild(document.createElement("div"));
             title.classList.add("title");
-            title.textContent = response.name || response.inferredName || response.displayName || WebInspector.UIString("(anonymous function)");
+            title.textContent = response.name || response.displayName || WebInspector.UIString("(anonymous function)");
             title.appendChild(functionSourceCodeLink);
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js

@@ -800 +800 @@
         document.removeEventListener("mouseup", this._mouseUpEventListener);
 
-        delete this._mouseMovedEventListener;
+        delete this._mouseMoveEventListener;
         delete this._mouseUpEventListener;
         delete this._mouseDownPosition;