Changeset 199037 in webkit

Timestamp:

Apr 4, 2016, 8:56:46 PM (10 years ago)

Author:

Simon Fraser

Message:

Don't crash when rendering form controls with Display List Drawing enabled
​https://bugs.webkit.org/show_bug.cgi?id=156122

Reviewed by Sam Weinig.

Don't attempt to paint form controls if display-list drawing is enabled, since
doing so attempts to get at a CGContextRef that doens't exist.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderTheme.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-04  Simon Fraser  <simon.fraser@apple.com>
+
+        Don't crash when rendering form controls with Display List Drawing enabled
+        https://bugs.webkit.org/show_bug.cgi?id=156122
+
+        Reviewed by Sam Weinig.
+        
+        Don't attempt to paint form controls if display-list drawing is enabled, since
+        doing so attempts to get at a CGContextRef that doens't exist.
+
+        * rendering/RenderTheme.cpp:
+        (WebCore::RenderTheme::paint):
+
 2016-04-04  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/rendering/RenderTheme.cpp

@@ -274 +274 @@
     }
     if (paintInfo.context().paintingDisabled())
+        return false;
+
+    if (UNLIKELY(paintInfo.context().isRecording()))
         return false;