Changeset 199044 in webkit

Timestamp:

Apr 4, 2016, 11:09:01 PM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[TexMap] resolveOverlaps() should be passed-in the first Region parameter via a reference
​https://bugs.webkit.org/show_bug.cgi?id=156158

Reviewed by Antonio Gomes.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::resolveOverlaps): Don't copy the Region object that's passed through
the first parameter by accepting a reference to the object instead. This does
modify the passed-in object, but these modifications don't have any effect on
any state via the call sites in TextureMapperLayer::computeOverlapRegions().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/TextureMapperLayer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-04  Zan Dobersek  <zdobersek@igalia.com>
+
+        [TexMap] resolveOverlaps() should be passed-in the first Region parameter via a reference
+        https://bugs.webkit.org/show_bug.cgi?id=156158
+
+        Reviewed by Antonio Gomes.
+
+        * platform/graphics/texmap/TextureMapperLayer.cpp:
+        (WebCore::resolveOverlaps): Don't copy the Region object that's passed through
+        the first parameter by accepting a reference to the object instead. This does
+        modify the passed-in object, but these modifications don't have any effect on
+        any state via the call sites in TextureMapperLayer::computeOverlapRegions().
+
 2016-04-04  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp

@@ -239 +239 @@
 }
 
-static void resolveOverlaps(Region newRegion, Region& overlapRegion, Region& nonOverlapRegion)
+static void resolveOverlaps(Region& newRegion, Region& overlapRegion, Region& nonOverlapRegion)
 {
     Region newOverlapRegion(newRegion);