Changeset 199083 in webkit

Timestamp:

Apr 5, 2016, 4:33:47 PM (11 years ago)

Author:

Beth Dakin

Message:

Make requestCandidatesForSelection available on any EditorClient
​https://bugs.webkit.org/show_bug.cgi?id=156253
-and corresponding-
rdar://problem/24661147

Reviewed by Dean Jackson.

Source/WebCore:

• loader/EmptyClients.h:
• page/EditorClient.h:

(WebCore::EditorClient::requestCandidatesForSelection):

Source/WebKit/mac:

• WebCoreSupport/WebEditorClient.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/loader/EmptyClients.h (modified) (1 diff)
• WebCore/page/EditorClient.h (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebCoreSupport/WebEditorClient.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-05  Beth Dakin  <bdakin@apple.com>
+
+        Make requestCandidatesForSelection available on any EditorClient
+        https://bugs.webkit.org/show_bug.cgi?id=156253
+        -and corresponding-
+        rdar://problem/24661147
+
+        Reviewed by Dean Jackson.
+
+        * loader/EmptyClients.h:
+        * page/EditorClient.h:
+        (WebCore::EditorClient::requestCandidatesForSelection):
+
 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 

trunk/Source/WebCore/loader/EmptyClients.h

@@ -469 +469 @@
     void didWriteSelectionToPasteboard() override { }
     void getClientPasteboardDataForRange(Range*, Vector<String>&, Vector<RefPtr<SharedBuffer>>&) override { }
+    void requestCandidatesForSelection(const VisibleSelection&) override { }
 
     void registerUndoStep(PassRefPtr<UndoStep>) override;

trunk/Source/WebCore/page/EditorClient.h

@@ -100 +100 @@
     virtual void didWriteSelectionToPasteboard() = 0;
     virtual void getClientPasteboardDataForRange(Range*, Vector<String>& pasteboardTypes, Vector<RefPtr<SharedBuffer>>& pasteboardData) = 0;
+    virtual void requestCandidatesForSelection(const VisibleSelection&) { }
 
     // Notify an input method that a composition was voluntarily discarded by WebCore, so that it could clean up too.

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-04-05  Beth Dakin  <bdakin@apple.com>
+
+        Make requestCandidatesForSelection available on any EditorClient
+        https://bugs.webkit.org/show_bug.cgi?id=156253
+        -and corresponding-
+        rdar://problem/24661147
+
+        Reviewed by Dean Jackson.
+
+        * WebCoreSupport/WebEditorClient.h:
+
 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 

trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h

@@ -171 +171 @@
 
 #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
-    void requestCandidatesForSelection(const WebCore::VisibleSelection&);
+    void requestCandidatesForSelection(const WebCore::VisibleSelection&) override;
     void handleRequestedCandidates(NSInteger, NSArray<NSTextCheckingResult *> *);
     void handleAcceptedCandidate(NSTextCheckingResult *);