Changeset 199403 in webkit

Timestamp:

Apr 12, 2016, 8:57:36 PM (10 years ago)

Author:

ap@apple.com

Message:

Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
​https://bugs.webkit.org/show_bug.cgi?id=155367

Reviewed by Darin Adler.

• Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):

Don't flakily consume the return code with waitpid, callers need to do waitpid on
their own. Not sure if this line of code was even intentional.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/system/executive.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-04-12  Alexey Proskuryakov  <ap@apple.com>
+
+        Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=155367
+
+        Reviewed by Darin Adler.
+
+        * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
+        Don't flakily consume the return code with waitpid, callers need to do waitpid on
+        their own. Not sure if this line of code was even intentional.
+
 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/system/executive.py

@@ -206 +206 @@
                 os.kill(pid, signal.SIGTERM)
                 os.kill(pid, signal.SIGKILL)
-                _ = os.waitpid(pid, os.WNOHANG)
             except OSError, e:
                 if e.errno == errno.EAGAIN: