Changeset 199573 in webkit

Timestamp:

Apr 14, 2016, 9:37:43 PM (10 years ago)

Author:

ap@apple.com

Message:

Some GuardMalloc bots are not happy when running many parallel processes
​https://bugs.webkit.org/show_bug.cgi?id=156614
rdar://problem/24711525

Reviewed by David Kilzer.

• Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/mac.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-04-14  Alexey Proskuryakov  <ap@apple.com>
+
+        Some GuardMalloc bots are not happy when running many parallel processes
+        https://bugs.webkit.org/show_bug.cgi?id=156614
+        rdar://problem/24711525
+
+        Reviewed by David Kilzer.
+
+        * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
+
 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/mac.py

@@ -156 +156 @@
         # We also want to throttle for leaks bots.
         if should_throttle_for_wk2 or self.get_option('leaks'):
-            default_count = int(.75 * default_count)
+            if self.get_option('guard_malloc'):
+                # Some 12 core Macs get a lot of tests time out when running 18 WebKitTestRunner processes (it's not clear what this depends on).
+                # Running 12 processes resolves this, and doesn't seem to introduce a measurable performance degradation on other machines.
+                default_count = int(.5 * default_count)
+            else:
+                default_count = int(.75 * default_count)
 
         # Make sure we have enough ram to support that many instances: