Changeset 200175 in webkit

Timestamp:

Apr 27, 2016, 11:46:49 PM (10 years ago)

Author:

ap@apple.com

Message:

Don't throttle GuardMalloc on 8-core Macs
​https://bugs.webkit.org/show_bug.cgi?id=157108

Reviewed by Alex Christensen.

This was making them slower unnecessarily.

• Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/mac.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-04-27  Alexey Proskuryakov  <ap@apple.com>
+
+        Don't throttle GuardMalloc on 8-core Macs
+        https://bugs.webkit.org/show_bug.cgi?id=157108
+
+        Reviewed by Alex Christensen.
+
+        This was making them slower unnecessarily.
+
+        * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
+
 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
 

trunk/Tools/Scripts/webkitpy/port/mac.py

@@ -156 +156 @@
         # We also want to throttle for leaks bots.
         if should_throttle_for_wk2 or self.get_option('leaks'):
-            if self.get_option('guard_malloc'):
-                # Some 12 core Macs get a lot of tests time out when running 18 WebKitTestRunner processes (it's not clear what this depends on).
-                # Running 12 processes resolves this, and doesn't seem to introduce a measurable performance degradation on other machines.
-                default_count = int(.5 * default_count)
-            else:
-                default_count = int(.75 * default_count)
+            default_count = int(.75 * default_count)
+
+        if should_throttle_for_wk2 and self.get_option('guard_malloc'):
+            # Some 12 core Macs get a lot of tests time out when running 18 WebKitTestRunner processes (it's not clear what this depends on).
+            # <rdar://problem/25750302>
+            default_count = min(default_count, 12)
 
         # Make sure we have enough ram to support that many instances: